Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm more useless generics #878

Merged
merged 3 commits into from
Nov 20, 2024
Merged

rm more useless generics #878

merged 3 commits into from
Nov 20, 2024

Conversation

tcoratger
Copy link
Contributor

Description

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@tcoratger tcoratger requested review from a team as code owners November 14, 2024 18:02
@tcoratger tcoratger requested review from mmagician, weikengchen and tyshko-rostyslav and removed request for a team November 14, 2024 18:02
@Pratyush Pratyush added this pull request to the merge queue Nov 20, 2024
Merged via the queue into arkworks-rs:master with commit 1aa8ed5 Nov 20, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pratyush Pratyush Pratyush approved these changes

@mmagician mmagician Awaiting requested review from mmagician mmagician is a code owner automatically assigned from arkworks-rs/maintainers

@weikengchen weikengchen Awaiting requested review from weikengchen weikengchen is a code owner automatically assigned from arkworks-rs/maintainers

@tyshko-rostyslav tyshko-rostyslav Awaiting requested review from tyshko-rostyslav tyshko-rostyslav is a code owner automatically assigned from arkworks-rs/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcoratger @Pratyush