Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dependency on ark-relations optional #146

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mzabaluev
Copy link

@mzabaluev mzabaluev commented Jul 28, 2024

Description

The std feature of ark-relations pulls in some hefty dependencies, including tracing-subscriber.
Remove the dependency on ark-relations/std because it is not needed.
Make ark-relations (without fetures) a conditional dependency, only enabled for r1cs where it is required.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

Remove the dependency on ark-relations/std because it is not needed.
Make ark-relations (without fetures) a conditional dependency,
only enabled for r1cs where it is required.
@mzabaluev mzabaluev requested a review from a team as a code owner July 28, 2024 18:17
@mzabaluev mzabaluev requested review from z-tech, mmagician and weikengchen and removed request for a team July 28, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant