This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
Add supplementary small group bases for some common fields #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we add a CHANGELOG entry for this? |
|
Depends on arkworks-rs/algebra#547. |
|
Needs to debug and fix the one related to secp256k1. |
|
Depends on arkworks-rs/algebra#550 |
weikengchen
commented
Dec 22, 2022
| ark-ff = { git = "https://github.com/arkworks-rs/algebra/", branch = "release-0.4-debug-secp256k1" } |
There was a problem hiding this comment.
Suggested change
| ark-ff = { git = "https://github.com/arkworks-rs/algebra/", branch = "release-0.4-debug-secp256k1" } | |
| ark-ff = { git = "https://github.com/arkworks-rs/algebra/", branch = "release-0.4" } |
weikengchen
commented
Dec 22, 2022
| ark-ff = { git = "https://github.com/arkworks-rs/algebra/", branch = "release-0.4-debug-secp256k1" } | ||
| ark-ec = { git = "https://github.com/arkworks-rs/algebra/", branch = "release-0.4-debug-secp256k1" } |
There was a problem hiding this comment.
Suggested change
| ark-ec = { git = "https://github.com/arkworks-rs/algebra/", branch = "release-0.4-debug-secp256k1" } | |
| ark-ec = { git = "https://github.com/arkworks-rs/algebra/", branch = "release-0.4" } |
weikengchen
commented
Dec 22, 2022
weikengchen
commented
Dec 22, 2022
| ark-ec = { git = "https://github.com/arkworks-rs/algebra/", branch = "release-0.4-debug-secp256k1" } | ||
| ark-poly = { git = "https://github.com/arkworks-rs/algebra/", branch = "release-0.4-debug-secp256k1" } | ||
| ark-serialize = { git = "https://github.com/arkworks-rs/algebra/", branch = "release-0.4-debug-secp256k1" } |
There was a problem hiding this comment.
Suggested change
| ark-serialize = { git = "https://github.com/arkworks-rs/algebra/", branch = "release-0.4-debug-secp256k1" } | |
| ark-serialize = { git = "https://github.com/arkworks-rs/algebra/", branch = "release-0.4" } |
weikengchen
commented
Dec 22, 2022
| ark-poly = { git = "https://github.com/arkworks-rs/algebra/", branch = "release-0.4-debug-secp256k1" } | ||
| ark-serialize = { git = "https://github.com/arkworks-rs/algebra/", branch = "release-0.4-debug-secp256k1" } | ||
| ark-algebra-test-templates = { git = "https://github.com/arkworks-rs/algebra/", branch = "release-0.4-debug-secp256k1" } |
There was a problem hiding this comment.
Suggested change
| ark-algebra-test-templates = { git = "https://github.com/arkworks-rs/algebra/", branch = "release-0.4-debug-secp256k1" } | |
| ark-algebra-test-templates = { git = "https://github.com/arkworks-rs/algebra/", branch = "release-0.4" } |
Pratyush
approved these changes
Dec 22, 2022
|
I think it is ready to merge. I will appreciate a cut of the alpha version. Is the next cut already scheduled? (I dare not to cut a release since the last time I did that was two years ago I think) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is related to arkworks-rs/algebra#547.
The idea is that for some TurboPlonk implementations, we use the small base not just when we run out of 2-arity, but we use it when constructing the larger domain (e.g., 6x larger). It is preferred to use 6x (by using a 3) rather than 8x.
This is used in the Noah library as a performance improvement.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Files changedin the Github PR explorerN/A:
Pendingsection inCHANGELOG.md