Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and fix some documentations and a minor optimization #36

Merged
merged 6 commits into from
Feb 2, 2023

Conversation

lovesh
Copy link
Contributor

@lovesh lovesh commented Nov 30, 2021

Documentation updates

  • Code comment describing what some of the symbols from the paper are renamed to
  • Fix name and comment on a test

Minor optimization reducing the input size to an MSM

Signed-off-by: lovesh lovesh.bond@gmail.com

Signed-off-by: lovesh <lovesh.bond@gmail.com>
Copy link
Member

@Pratyush Pratyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@Pratyush
Copy link
Member

Could you add a CHANGELOG entry, and then we can merge this!

Signed-off-by: lovesh <lovesh.bond@gmail.com>
@lovesh
Copy link
Contributor Author

lovesh commented Dec 17, 2021

@Pratyush Done.

src/generator.rs Outdated Show resolved Hide resolved
@Pratyush Pratyush merged commit 23a2af0 into arkworks-rs:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants