Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(affine-curve): ensure ProjectiveCurve can mul with Affine scalars #121

Merged
merged 3 commits into from
Mar 2, 2020

Conversation

gakonst
Copy link
Contributor

@gakonst gakonst commented Mar 2, 2020

As title. This was introduced in bfe7c3c.

Compiler downstream was suggesting:

479 |             next_region = next_region.double();
    |                                       ^^^^^^ no implementation for <G as algebra_core::curves::AffineCurve>::Projective *= <G as algebra_core::curves::AffineCurve>::ScalarField

@Pratyush
Copy link
Member

Pratyush commented Mar 2, 2020

Bleh this is a recurring issue. I filed a bug against rust: rust-lang/rust#69640, but I'll merge this in the meanwhile. Thanks for the PR!

Copy link
Member

@Pratyush Pratyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits

algebra-core/src/curves/mod.rs Outdated Show resolved Hide resolved
algebra-core/src/curves/mod.rs Outdated Show resolved Hide resolved
algebra-core/src/curves/mod.rs Outdated Show resolved Hide resolved
@Pratyush Pratyush merged commit 1c5f789 into arkworks-rs:master Mar 2, 2020
@gakonst gakonst deleted the affine-curve-mulassign branch March 2, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants