r1cs replaced with gr1cs #378
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pratyush
reviewed
Aug 7, 2024
|
|
||
| /////////////////////////////////////////////////////////////////////////////////////// | ||
|
|
||
| /// An Rank-One `ConstraintSystem`. Enforces constraints of the form |
There was a problem hiding this comment.
Suggested change
| /// An Rank-One `ConstraintSystem`. Enforces constraints of the form | |
| /// A Rank-1 `ConstraintSystem`. Enforces constraints of the form |
| /// An Rank-One `ConstraintSystem`. Enforces constraints of the form | ||
| /// `L_i(⟨M_{i,1}, z⟩ , ⟨M_{i,2}, z⟩ , ..., ⟨M_{i,t_i}, z⟩)=0`, where L_i is a | ||
| /// local predicate, and `M_{i,j}`s are linear combinations over variables, and | ||
| /// `z` is the concrete assignment to these variables. refer to //TODO: Paper Url |
| )?; | ||
| } | ||
| self.enforce_constraint(R1CS_PREDICATE_LABEL, vec![a, b, c]) | ||
| // if self.should_construct_matrices() { |
| /// Add a new vector of linear combinations to the constraint system. | ||
| pub fn new_lc_vec( | ||
| &mut self, | ||
| lc_vec: Vec<LinearCombination<F>>, |
There was a problem hiding this comment.
Suggested change
| lc_vec: Vec<LinearCombination<F>>, | |
| lc_vec: impl IntoIterator<Item = LinearCombination<F>>, |
I can pass in [lc_1, lc_2, lc_3], or I can pass in vec![lc_1, lc_2, lc_3]. The benefit is that this avoids allocations
Comment on lines
+199
to
+206
| let mut constraints: Constraint = Vec::new(); | ||
| for lc in lc_vec { | ||
| let var = self.new_lc(lc)?; | ||
| match var { | ||
| Variable::SymbolicLc(index) => constraints.push(index), | ||
| _ => return Err(SynthesisError::UnexpectedVariable), | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| let mut constraints: Constraint = Vec::new(); | |
| for lc in lc_vec { | |
| let var = self.new_lc(lc)?; | |
| match var { | |
| Variable::SymbolicLc(index) => constraints.push(index), | |
| _ => return Err(SynthesisError::UnexpectedVariable), | |
| } | |
| } | |
| let constraints: Vec<_> = lc_vec.into_iter().map(|lc| { | |
| let var = self.new_lc(lc)?; | |
| match var { | |
| Variable::SymbolicLc(index) => constraints.push(index), | |
| _ => return Err(SynthesisError::UnexpectedVariable), | |
| } | |
| }).collect(); |
Comment on lines
+368
to
+373
| .predicate_traces | ||
| .get(label) | ||
| .unwrap() | ||
| .get(unsatisfied_constraint) | ||
| .unwrap() | ||
| .as_ref() |
There was a problem hiding this comment.
Suggested change
| .predicate_traces | |
| .get(label) | |
| .unwrap() | |
| .get(unsatisfied_constraint) | |
| .unwrap() | |
| .as_ref() | |
| .predicate_traces[&label][unsatisfied_constraint] | |
| .as_ref() |
Comment on lines
+379
to
+381
| format!("{} - {}", label.clone(), unsatisfied_constraint) | ||
| }, | ||
| |t| format!("{}", t), |
There was a problem hiding this comment.
Suggested change
| format!("{} - {}", label.clone(), unsatisfied_constraint) | |
| }, | |
| |t| format!("{}", t), | |
| format!("{} - {unsatisfied_constraint}", &label) | |
| }, | |
| |t| format!("{t}"), |
| use lookup_constraint::LookupConstraint; | ||
| use polynomial_constraint::PolynomialConstraint; | ||
|
|
||
| // use crate::{gr1cs::ConstraintSystemRef, utils::Result}; |
There was a problem hiding this comment.
Suggested change
| // use crate::{gr1cs::ConstraintSystemRef, utils::Result}; |
Comment on lines
+23
to
+25
| where | ||
| PolynomialConstraint<F>: Evaluatable<F>, | ||
| LookupConstraint<F>: Evaluatable<F>, |
There was a problem hiding this comment.
Suggested change
| where | |
| PolynomialConstraint<F>: Evaluatable<F>, | |
| LookupConstraint<F>: Evaluatable<F>, |
Comment on lines
+17
to
+19
| pub trait Evaluatable<F> { | ||
| fn evaluate(&self, point: Vec<F>) -> F; | ||
| } |
There was a problem hiding this comment.
Add documentation for trait, and change point to variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a major refactor for migrating to GR1CS infrastructure
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the Github PR explorer