Added NavMesh.ToWriter() in case you don't need a navmesh file #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arl
reviewed
Mar 7, 2024
| } | ||
|
|
||
| // ToWriter writes binary navigation mesh to io.Writer. | ||
| func (m *NavMesh) ToWriter(w io.Writer) error { |
There was a problem hiding this comment.
Good idea. It would be even better if the function was called WriteTo and had the following signature:
WriteTo(w Writer) (n int64, err error)since that would make NavMesh implement the io.WriterTo interface.
Comment on lines
+180
to
+199
| // Returns binary navigation mesh file size. | ||
| func (m *NavMesh) Size() int32 { | ||
| var header navMeshSetHeader | ||
| header.Params = m.Params | ||
| hSize := header.Size() | ||
|
|
||
| var tilesSize int32 = 0 | ||
| var tileHeader navMeshTileHeader | ||
| for i := int32(0); i < m.MaxTiles; i++ { | ||
| tile := &m.Tiles[i] | ||
| if tile.DataSize == 0 { | ||
| continue | ||
| } | ||
|
|
||
| tilesSize += int32(tileHeader.Size()) + tile.DataSize | ||
| } | ||
|
|
||
| return int32(hSize) + tilesSize | ||
| } | ||
|
|
There was a problem hiding this comment.
What's the use case for that method?
By using the WriteTo method (with the new signature), one also obtains the final file size.
If you're not interested by the data, but just by its size, you could something like
var navMesh *NavMesh
n, err := navMesh.WriteTo(io.discard)
if err {...}
fmt.Println("nav mesh file size:", n)Let me know if that works for you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.