Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mutating hook for binoculars panicking on nil pointer dereference #294

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

dejanzele
Copy link
Member

No description provided.

dave-gantenbein
dave-gantenbein previously approved these changes Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd140a6) 84.19% compared to head (57df4c3) 84.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #294   +/-   ##
=======================================
  Coverage   84.19%   84.19%           
=======================================
  Files          15       15           
  Lines        3441     3441           
=======================================
  Hits         2897     2897           
  Misses        381      381           
  Partials      163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dejanzele dejanzele merged commit bda0e29 into armadaproject:main Dec 4, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants