Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: segfault when resources not supplied in scheduler spec #298

Closed
wants to merge 1 commit into from
Closed

fix: segfault when resources not supplied in scheduler spec #298

wants to merge 1 commit into from

Conversation

jpoler
Copy link
Contributor

@jpoler jpoler commented Apr 16, 2024 •
edited
Loading

This is a fix for a segfault that occurs when resources are nil in the scheduler spec. The current code tries to dereference *scheduler.Spec.Resources outside of the conditional that checks for nil.

@Sovietaced Sovietaced mentioned this pull request May 31, 2024
Merged
@Sovietaced
Copy link
Contributor

@dejanzele this can be closed

@dejanzele
Copy link
Member

Closing this in favour of #302

@dejanzele dejanzele closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpoler @Sovietaced @dejanzele