Making executor consider all pending pods as requiring resource #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we consider pods requiring resource as: - Those running on "processing nodes" - Those that are "managed" by Armada and not assigned a node (i.e Pending) The issue with this is that pods that are pending and not "managed" are not considered by Armada So Armada keeps scheduling pods to take up the space this pending pod wants to use This change should make it easier for non-Armada pods to get on the cluster (Pending -> Scheduled) - As we now leave space for it to get on
|
Closing old PR |
svc-gh-ghzonetrans-p
pushed a commit
that referenced
this pull request
Oct 23, 2024
* fix test * lint
d80tb7
added a commit
that referenced
this pull request
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we consider pods requiring resource as:
The issue with this is that pods that are pending and not "managed" are not considered by Armada
So Armada keeps scheduling pods to take up the space this pending pod wants to use
This change should make it easier for non-Armada pods to get on the cluster (Pending -> Scheduled)