Scheduler: Refactor nodedb create node #3970
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function
nodedb.NodeDb.create
currently does two thingsschedulerobjects.Node
intointernaltypes.Node
This PR breaks
nodedb.NodeDb.create
into two, so insteadinternaltypes.Node.FromSchedulerObjectsNode
.nodedb.NodeDb.AddNodeToDb
.Going forward this will allow us to gradually replace
schedulerobjects.Node
withinternaltypes.Node
. EventuallyFromSchedulerObjectsNode
can be called straight after loading the node from the db, and the scheduler can use onlyinternaltypes.Node
internally.