Some more simulator improvements #4007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
d80tb7
commented
Oct 16, 2024
d80tb7
commented
- Remove some unused code
- Add back in fast forward
- Hard code all scheduler rate limiting to be unlimited as any other value is objectively wrong until we make the rate limiter respect the simulator clock.
- Don't clone the config- this was only previously needed as the simulator accessed this config from multiple threads and this is no longer the case.
- Scheduler now logs every 15 seconds of elapsed time rather than every 60 seconds of simulated time.
robertdavidsmith
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.