Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes (#259) #4013

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Bug fixes (#259) #4013

merged 1 commit into from
Oct 21, 2024

Conversation

MustafaI
Copy link
Contributor

Summary of changes:

  • Fixes a bug where mutliple ingestion pipelines attempt to start the same metrics server, resulting in a panic
  • Validating queue label metric names to avoid scheduler panics if labels aren't formatted correctly

@mustafai-gr
Bug fixes (#259)
19e62ac 
* Starting metric server before running ingestion pipeline

Fixes a bug where mutliple ingestion pipelines attempt to start the same metrics server, resulting in a panic

* Validating queue label metric names
@MustafaI MustafaI merged commit 7115d29 into master Oct 21, 2024
20 checks passed
@MustafaI MustafaI deleted the sendToGitHub/metric-validation branch October 21, 2024 09:09
@svc-gh-ghzonetrans-p svc-gh-ghzonetrans-p restored the sendToGitHub/metric-validation branch October 21, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertdavidsmith robertdavidsmith robertdavidsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MustafaI @robertdavidsmith @mustafai-gr