Scala client: enhance mock Armada server for unit tests #4214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a map to track queues created/queried/delete by Scala clients, for sanity-checking during unit-testing. Fixes G-Research/spark#40 Signed-off-by: Rich Scott <richscott@sent.com>
Use a map to track job creation/queries/deletion. Also, set "allow globbing" option for sbt compiler via .sbtopts file. Signed-off-by: Rich Scott <richscott@sent.com>
Signed-off-by: Rich Scott <richscott@sent.com>
GeorgeJahad
reviewed
Feb 18, 2025
client/scala/scala-armada-client/src/test/scala/ArmadaClientSuite.scala
Outdated
Show resolved
Hide resolved
GeorgeJahad
reviewed
Feb 18, 2025
GeorgeJahad
reviewed
Feb 18, 2025
GeorgeJahad
previously approved these changes
Feb 18, 2025
Signed-off-by: Rich Scott <richscott@sent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add better checking of pre-requisite resources (existence of specified queue when submitting a job, etc) in the Armada Server mock for the Scala client. Simple maps are used to track creation/deletion of queues and jobs.
Several Armada client convenience functions now more accurately return GRPC runtime exceptions (instead of just an empty List or object) in the same way that the Scala binding would with a real Armada cluster. JobIDs are now generated using ULIDs.
A
client/scala/scala-armada-client/.sbtoptshas been created, with a Java define directive to squelch the sbt warnings about converting relative (e.g.../../../) paths to absolute, so a baresbt buildorsbt testshould be quieter.