Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use Objective-C generics #58

Closed
armadsen opened this issue Jun 28, 2015 · 2 comments
Closed

Update to use Objective-C generics #58

armadsen opened this issue Jun 28, 2015 · 2 comments
Assignees
@armadsen
Labels
enhancement
Milestone
2.0

Comments

@armadsen
Copy link
Owner

This provides some advantages when using ORSSerialPort from Objective-C, but is particularly good for Swift integration. It should wait for release in master until Xcode 7.0 is no longer in beta, unless the feature can be conditionally compiled as is being done with nullability annotations.
@armadsen armadsen self-assigned this Jun 28, 2015
@armadsen armadsen added this to the 2.0 milestone Jun 28, 2015
@armadsen
Copy link
Owner Author

It seems that __has_feature(objc_generics) can be used to check for generics support.

armadsen pushed a commit that referenced this issue Jun 29, 2015
Issue #58: Annotated ORSSerialPort API using ObjC generics.
14e493f
@armadsen
Copy link
Owner Author

Upon further investigation, this should actually wait until Xcode 7.0 final is released but can be made backwards compatible using __has_feature(objc_generics). This is because it's not really a completely useful change until the Swift example code can take advantage of it, and that requires updating to Swift 2.0 (see #60).

@armadsen armadsen modified the milestones: 2.1, 2.0 Jul 6, 2015
@armadsen armadsen mentioned this issue Aug 31, 2015
Closed
@armadsen armadsen modified the milestones: 2.0, 2.1 Aug 31, 2015
armadsen added a commit that referenced this issue Aug 31, 2015
@armadsen
Issue #58: Annotated new packetDescriptors property for ObjC generics.
4af7f7c
armadsen added a commit that referenced this issue Aug 31, 2015
@armadsen
Merge pull request #69 from armadsen/Issue58
6fa60e8 
Issue #58: Add Objective-C generics annotations
armadsen added a commit that referenced this issue Aug 31, 2015
@armadsen
Fixed bad declaration of -packetDescriptors (Issue #58).
857b507
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@armadsen armadsen

Labels
enhancement
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@armadsen