Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BroadcastChannel #150

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Add BroadcastChannel #150

merged 2 commits into from
Sep 28, 2023

Conversation

armanbilge
Copy link
Owner

@toddburnside
Copy link

This looks great! So we just need to create Serializers for our messages? Thanks @armanbilge!

toddburnside
toddburnside approved these changes Sep 28, 2023
View reviewed changes
Copy link

@toddburnside toddburnside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👏

@armanbilge
Copy link
Owner Author

armanbilge commented Sep 28, 2023 •
edited
Loading

So we just need to create Serializers for our messages?

Yes, exactly. I think the Explore messages are already serializable so it is just identity/casting. The big picture goal is to offer a combinator API to build Serializers for arbitrary data classes e.g. similar to skunk codecs.

@armanbilge armanbilge merged commit 22c2365 into main Sep 28, 2023
@armanbilge armanbilge deleted the pr/broadcast-channel branch September 28, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddburnside toddburnside toddburnside approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armanbilge @toddburnside