Introduce Dom typeclass
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some design notes: this is a bit of a different style than the rest of the library, which creates wrappers for JavaScript classes. The reasoning is that the allocation cost of a wrapper for every single element would just be really bad for performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have gone crazy 😅
The goal is to introduce a typeclass for interacting with the DOM without needing
AsyncorSyncand stuff.There is a stupid amount of work to do, essentially to re-wrap all the scala-js-dom APIs. I started with just what I need from Calico. We'll have to see how this goes. Odds are that APIs will be added as-needed.
Scala 3 only, because
opaque typeandextensionand stuff.