-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kASLR for rk3399 u-boot #4311
Conversation
Could someone with UART run Maybe @paolosabatino if you have one? =) |
I have the equipment, but unfortunately me and the equipment will be very far in the next week and can't give immediate support 😮💨 |
I have a serial console working now. It looks like u-boot still can't find the RNG, even with this patch. Trying to figure out where my mistake is.. |
The manual clocks screw it up, so remove those.
For anyone reading this, my mistake was having the clocks manually defined in u-boot. Getting rid of those seems to have got it working. |
@igorpecovnik this commit is only adding the feature to the R4S u-boot config, but attempting to use it for all boards via the shared bootscript. I've been asked what the extra boot noise is "unknown command 'kaslrseed' - try 'help' |
@Tonymac32 The correct fix is to add kASLR to those other boards. IMO the warning is a good warning, as no kASLR is not a good thing. |
No disagreement from me, however upon review this should heave been requested before merge. Do you know the status of this feature on RK3328, RK3588, RK3568, etc? |
It was mentioned in #4306 (comment). Ideally, this should be eventually addressed upstream in u-boot for all devices with a hardware RNG. The main motivation here is that I have some of these RK3399 devices, and was willing to test/maintain the patch. I don't know the status of this feature on other boards, that would require users to tell us which chipset they're using when they see the warning message. (e.g. I still don't know what device you're using, other than it's probably not a R4S.) |
WIP