Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

board: orangepi-5-plus: Add mainline U-Boot for edge kernel #6719

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

ColorfulRhino
Copy link
Collaborator

@ColorfulRhino ColorfulRhino commented Jun 9, 2024

Description

Helping @alexl83 with his OrangePi 5 Plus 😄

Support for this board with SPI image was added to U-Boot this january: u-boot/u-boot@7c084fd

Also add the latest DDR and BL31 blobs, this should fix issues like recently on the NanoPC T6.

Marked as WIP to give room for testing.

How Has This Been Tested?

  • Build success: ./compile.sh BOARD=orangepi5-plus BRANCH=edge RELEASE=trixie EXPERT=yes KERNEL_CONFIGURE=no BUILD_MINIMAL=no BUILD_DESKTOP=no uboot
  • @alexl83 please test freshly built edge kernel image
  • @alexl83 please test freshly built vendor kernel image (vendor u-boot should be applied)
  • @alexl83 please test edge image on SD card while vendor U-Boot is installed in SPI (or wherever it lives when it comes from the factory)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@ColorfulRhino ColorfulRhino added Work in progress Unfinished / work in progress 08 Milestone: Third quarter release labels Jun 9, 2024
@github-actions github-actions bot added size/small PR with less then 50 lines Hardware Hardware related like kernel, U-Boot, ... labels Jun 9, 2024
@alexl83
Copy link
Contributor

alexl83 commented Jun 9, 2024

Thanks @ColorfulRhino - will do it asap!
Starting tests in a couple hours tops!

@alexl83
Copy link
Contributor

alexl83 commented Jun 9, 2024

Description

Helping @alexl83 with his OrangePi 5 Plus 😄

Support for this board with SPI image was added to U-Boot this january: u-boot/u-boot@7c084fd

Also add the latest DDR and BL31 blobs, this should fix issues like recently on the NanoPC T6.

Marked as WIP to give room for testing.

How Has This Been Tested?

  • Build success: ./compile.sh BOARD=orangepi5-plus BRANCH=edge RELEASE=trixie EXPERT=yes KERNEL_CONFIGURE=no BUILD_MINIMAL=no BUILD_DESKTOP=no uboot

  • @alexl83 please test freshly built edge kernel image

  • @alexl83 please test freshly built vendor kernel image (vendor u-boot should be applied)

  • @alexl83 please test edge image on SD card while vendor U-Boot is installed in SPI (or wherever it lives when it >comes from the factory)

Test Report and protocol:

  1. built vendor image from trunk + this PR --> pulls 2017.9
  2. flashed and booted vendor image from sdcard --> ok
  3. configured vendor image (armbian-firstrun) --> ok
  4. rebooted vendor image --> ok
  5. installed vendor u-boot to mtd0 --> ok
  6. built edge image from trunk + this PR --> pulls 2024.07
  7. flashed and cold-booted edge image from sdcard --> ok
  8. configured edge image (armbian-firstrun) --> ok
  9. rebooted edge image --> ok
  10. erased spi flash mtd0 --> ok
  11. rebooted edge image --> ok
  12. cold-booted edge image --> ok

Basically it's a very verbose "IT WORKS!!!!"

@ColorfulRhino
Copy link
Collaborator Author

Awesome, thanks for testing! Enjoy :)

Let's wait if @efectn maybe has a comment on this.

@ColorfulRhino ColorfulRhino added Build Executing build train (permission needed) and removed Work in progress Unfinished / work in progress Build Executing build train (permission needed) labels Jun 9, 2024
@efectn
Copy link
Member

efectn commented Jun 11, 2024

Awesome, thanks for testing! Enjoy :)

Let's wait if @efectn maybe has a comment on this.

Will test it next days. Maybe we can also use mainline uboot for legacy images in the future

efectn
efectn previously approved these changes Jun 16, 2024
@ColorfulRhino ColorfulRhino added the Ready to merge Reviewed, tested and ready for merge label Jun 17, 2024
@ColorfulRhino ColorfulRhino merged commit 01edf1c into armbian:main Jun 17, 2024
9 checks passed
@ColorfulRhino ColorfulRhino deleted the opi5plus-uboot branch June 17, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 Milestone: Third quarter release Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

3 participants