Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extlinux: add DEFAULT_OVERLAYS support #6744

Merged
merged 1 commit into from
Jun 14, 2024
Merged

extlinux: add DEFAULT_OVERLAYS support #6744

merged 1 commit into from
Jun 14, 2024

Conversation

efectn
Copy link
Member

@efectn efectn commented Jun 14, 2024 •
edited by jira bot
Loading

Description

DEFAULT_OVERLAYS is only supported for bootscripts and is not used by Extlinux. Let's add it to Extlinux to fix some extensions like mesa-vpu.

Jira reference number AR-2370

How Has This Been Tested?

  • Khadas Edge2 now works well with mesa-vpu extension using panthor

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@efectn efectn requested a review from a team as a code owner June 14, 2024 17:52
@github-actions github-actions bot added the size/small PR with less then 50 lines label Jun 14, 2024
viraniac
viraniac approved these changes Jun 14, 2024
View reviewed changes
Copy link
Collaborator

@viraniac viraniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 08 Milestone: Third quarter release labels Jun 14, 2024
@igorpecovnik igorpecovnik merged commit f28bb4e into armbian:main Jun 14, 2024
9 of 11 checks passed
@ColorfulRhino
Copy link
Collaborator

ColorfulRhino commented Jun 14, 2024 •
edited
Loading

@efectn @igorpecovnik This PR is causing errors: https://github.com/armbian/build/actions/runs/9520292845/job/26245281050

@efectn
Copy link
Member Author

efectn commented Jun 14, 2024

@efectn @igorpecovnik This PR is causing errors: https://github.com/armbian/build/actions/runs/9520292845/job/26245281050

It seems [@] needs to be replaced by [*]. Can you create a PR for that? I'm not at the PC rn

@ColorfulRhino ColorfulRhino mentioned this pull request Jun 14, 2024
Merged
1 task
@ColorfulRhino
Copy link
Collaborator

It seems [@] needs to be replaced by [*]. Can you create a PR for that? I'm not at the PC rn

I got you #6746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viraniac viraniac viraniac approved these changes

Assignees
No one assigned
Labels
08 Milestone: Third quarter release Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@efectn @ColorfulRhino @viraniac @igorpecovnik