Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix armbian-leds-state-save.sh: #6765

Merged
merged 4 commits into from
Jun 20, 2024
Merged

fix armbian-leds-state-save.sh: #6765

merged 4 commits into from
Jun 20, 2024

Conversation

alexl83
Copy link
Contributor

@alexl83 alexl83 commented Jun 19, 2024 •
edited
Loading

Description

don't store parameters for networking link establishment (avoid ghost wan/lan/eth link led up on bootup)

How Has This Been Tested?

  • built nanopi-r5c, booted with wan cable plugged, rebooted unplugging it --> wan led was correctly NOT powered up

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@alexl83
fix armbian-leds-state-save.sh:
45af25b 
don't  store parameters for networking link establishment (avoid ghost wan/lan/eth link led up on bootup)
@alexl83 alexl83 requested a review from a team as a code owner June 19, 2024 18:41
@github-actions github-actions bot added the size/small PR with less then 50 lines label Jun 19, 2024
@ColorfulRhino
Copy link
Collaborator

ColorfulRhino commented Jun 19, 2024 •
edited
Loading

Interesting! I have never noticed this before 😄 What did you do to trigger this problem? Do you have to unplug the ethernet cable when it's powered off?

Edit: Yes. I can confirm the issue after a test 👍

@github-actions github-actions bot added the Framework Framework components label Jun 19, 2024
@ColorfulRhino ColorfulRhino added Ready to merge Reviewed, tested and ready for merge 08 Milestone: Third quarter release Bugfix Pull request is fixing a bug labels Jun 19, 2024
@igorpecovnik igorpecovnik merged commit 5711d09 into armbian:main Jun 20, 2024
7 checks passed
@alexl83 alexl83 deleted the fix_network_leds_restore branch June 23, 2024 13:37
@ColorfulRhino ColorfulRhino mentioned this pull request Jul 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ColorfulRhino ColorfulRhino ColorfulRhino approved these changes

Assignees
No one assigned
Labels
08 Milestone: Third quarter release Bugfix Pull request is fixing a bug Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexl83 @ColorfulRhino @igorpecovnik