-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cleanup] Remove old torrents #6829
Conversation
I am ok with torrents, but for changes on khadas legacy compilers is up to @viraniac |
Yes, I have requested a review from him 👍 |
I don't see gcc-linaro-7.4.1-2019.02-aarch64_aarch64-elf.tar.xz file on dl.armbian.com. Unless you are uploading that as well, I will suggest to leave it alone. |
I was confused since I explicitely checked. But turns out the "elf" part is the detail that's different from all the other files. I only checked |
- Also remove 10+ years old compilers from `external_toolchains.sh`
c6c82c8
to
ea1d4aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current changes looks good to me. We can remove download_external_toolchains function, but that can also be done in seperate PR
Alright thanks! I'll see if I can remove the whole code path for SKIP_EXTERNAL_TOOLCHAINS in a separate PR 👍 |
IIRC we used to have this for rootfs caching, but this is also deprecated after it was moved to OCI. |
Description
This PR is part of the big repo cleanup ✨
I tried to find references for the old toolchains. The only reference I could find that was actively using an external toolchain in meson-s4t7. There I have bumped the compiler from 7.3.1 to 7.4.1. A 2019 compiler seems like a good fit to compile a 2019 u-boot :) @viraniac
Other than that, I found only this:
build/lib/functions/host/external-toolchains.sh
Lines 26 to 37 in 560993a
I have kept every torrent that is referenced in that list, apart from the first few ones which are 10+ years old now and would probably not really work well on a modern machine anyway.
Please let me know if you know that a certain compiler/torrent is still needed.
Checklist: