Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Remove old torrents #6829

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

ColorfulRhino
Copy link
Collaborator

Description

This PR is part of the big repo cleanup ✨

I tried to find references for the old toolchains. The only reference I could find that was actively using an external toolchain in meson-s4t7. There I have bumped the compiler from 7.3.1 to 7.4.1. A 2019 compiler seems like a good fit to compile a 2019 u-boot :) @viraniac

Other than that, I found only this:

local toolchains=(
"gcc-linaro-aarch64-none-elf-4.8-2013.11_linux.tar.xz"
"gcc-linaro-arm-none-eabi-4.8-2014.04_linux.tar.xz"
"gcc-linaro-arm-linux-gnueabihf-4.8-2014.04_linux.tar.xz"
"gcc-linaro-7.4.1-2019.02-x86_64_arm-linux-gnueabi.tar.xz"
"gcc-linaro-7.4.1-2019.02-x86_64_aarch64-linux-gnu.tar.xz"
"gcc-arm-8.3-2019.03-x86_64-arm-linux-gnueabihf.tar.xz"
"gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu.tar.xz"
"gcc-arm-9.2-2019.12-x86_64-arm-none-linux-gnueabihf.tar.xz"
"gcc-arm-9.2-2019.12-x86_64-aarch64-none-linux-gnu.tar.xz"
"gcc-arm-11.2-2022.02-x86_64-arm-none-linux-gnueabihf.tar.xz"
"gcc-arm-11.2-2022.02-x86_64-aarch64-none-linux-gnu.tar.xz"

I have kept every torrent that is referenced in that list, apart from the first few ones which are 10+ years old now and would probably not really work well on a modern machine anyway.

Please let me know if you know that a certain compiler/torrent is still needed.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@ColorfulRhino ColorfulRhino requested a review from viraniac June 29, 2024 10:35
@ColorfulRhino ColorfulRhino requested review from a team and igorpecovnik as code owners June 29, 2024 10:35
@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines Hardware Hardware related like kernel, U-Boot, ... Framework Framework components labels Jun 29, 2024
@igorpecovnik
Copy link
Member

I am ok with torrents, but for changes on khadas legacy compilers is up to @viraniac

@igorpecovnik igorpecovnik added 08 Milestone: Third quarter release Needs review Seeking for review labels Jun 29, 2024
@ColorfulRhino
Copy link
Collaborator Author

I am ok with torrents, but for changes on khadas legacy compilers is up to @viraniac

Yes, I have requested a review from him 👍

@viraniac
Copy link
Collaborator

I don't see gcc-linaro-7.4.1-2019.02-aarch64_aarch64-elf.tar.xz file on dl.armbian.com. Unless you are uploading that as well, I will suggest to leave it alone.

@ColorfulRhino
Copy link
Collaborator Author

I don't see gcc-linaro-7.4.1-2019.02-aarch64_aarch64-elf.tar.xz file on dl.armbian.com. Unless you are uploading that as well, I will suggest to leave it alone.

I was confused since I explicitely checked. But turns out the "elf" part is the detail that's different from all the other files. I only checked 7.4.1 - yup, aarch64 - yup. Sorry! This is what reviews are for, thanks for catching it 👍

- Also remove 10+ years old compilers from `external_toolchains.sh`
Copy link
Collaborator

@viraniac viraniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current changes looks good to me. We can remove download_external_toolchains function, but that can also be done in seperate PR

@ColorfulRhino
Copy link
Collaborator Author

ColorfulRhino commented Jun 30, 2024

Alright thanks! I'll see if I can remove the whole code path for SKIP_EXTERNAL_TOOLCHAINS in a separate PR 👍
Not sure if the torrents serve any other purpose than for the external toolchains or if they can also be removed in the same step.

@ColorfulRhino ColorfulRhino merged commit 0441d2e into armbian:main Jun 30, 2024
@igorpecovnik
Copy link
Member

Not sure if the torrents serve any other purpose than for the external toolchains or if they can also be removed in the same step.

IIRC we used to have this for rootfs caching, but this is also deprecated after it was moved to OCI.

@ColorfulRhino ColorfulRhino deleted the clean-torrents branch July 2, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
08 Milestone: Third quarter release Framework Framework components Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review size/medium PR with more then 50 and less then 250 lines
Development

Successfully merging this pull request may close these issues.

4 participants