Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nanopi-r5c: add general u-boot 2024.07 patches #7056

Merged
merged 2 commits into from
Aug 10, 2024
Merged

nanopi-r5c: add general u-boot 2024.07 patches #7056

merged 2 commits into from
Aug 10, 2024

Conversation

alexl83
Copy link
Contributor

@alexl83 alexl83 commented Aug 10, 2024

Description

nanopi-r5c u-boot patch dir has been detached to allow version bump to 2024.07 and add kaslr support patchset
this PR includes general 2024.07 patches to board such as:

  • general-btrfs-fix-out-of-bounds-write.patch
  • general-dwc-otg-usb-fix.patch
  • general-dw-hdmi-disable.patch
  • general-fix-inno-phy-macro.patch

note to users and maintainers: sorry for forgetting to include those patches in my first PR

How Has This Been Tested?

  • Succesfully built and ran u-boot 2024.07

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@github-actions github-actions bot added size/large PR with 250 lines or more Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Aug 10, 2024
@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines and removed size/large PR with 250 lines or more labels Aug 10, 2024
paolosabatino
paolosabatino approved these changes Aug 10, 2024
View reviewed changes
Copy link
Contributor

@paolosabatino paolosabatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty safe to me

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 08 Milestone: Third quarter release labels Aug 10, 2024
@igorpecovnik igorpecovnik merged commit 3ad547f into armbian:main Aug 10, 2024
11 checks passed
@ColorfulRhino
Copy link
Collaborator

nanopi-r5c u-boot patch dir has been detached to allow version bump to 2024.07

Why has this been detached? I don't quite understand. Why can't it use the normal 2024.07 folder and the general kaslr patches apply to the general 2024.07 U-Boot so other boards can use it as well?

@alexl83
Copy link
Contributor Author

alexl83 commented Aug 11, 2024 •
edited
Loading

nanopi-r5c u-boot patch dir has been detached to allow version bump to 2024.07

Why has this been detached? I don't quite understand. Why can't it use the normal 2024.07 folder and the general kaslr patches apply to the general 2024.07 U-Boot so other boards can use it as well?

Because I wan't sure about any potential impact/fallout for other boards - I duplicated general patches in detached dir and planned to add kaslr to general 2024.07 dir in a separate PR tagget for milestone 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paolosabatino paolosabatino paolosabatino approved these changes

@Manouchehri Manouchehri Awaiting requested review from Manouchehri

@TRSx80 TRSx80 Awaiting requested review from TRSx80

@Tonymac32 Tonymac32 Awaiting requested review from Tonymac32

@ahoneybun ahoneybun Awaiting requested review from ahoneybun

@amazingfate amazingfate Awaiting requested review from amazingfate

@brentr brentr Awaiting requested review from brentr

@catalinii catalinii Awaiting requested review from catalinii

@clee clee Awaiting requested review from clee

@joekhoobyar joekhoobyar Awaiting requested review from joekhoobyar

@krachlatte krachlatte Awaiting requested review from krachlatte

@rpardini rpardini Awaiting requested review from rpardini

@schwar3kat schwar3kat Awaiting requested review from schwar3kat

@igorpecovnik igorpecovnik Awaiting requested review from igorpecovnik igorpecovnik is a code owner

Assignees
No one assigned
Labels
08 Milestone: Third quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexl83 @ColorfulRhino @paolosabatino @igorpecovnik