-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempt to fix pr announce for all contributors #7081
Conversation
The earlier attempt seem to limit announces to repository members for some reason. This attempt limits to the repo only, therefore forks should not be affected. Not sure if it works, but there is only one way to find out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! I was just about to file a bug/issue.
Although as far as my GH Actions knowledge goes, using the ${{ ... }}
is best practice, so I'd not remove that.
Looks like it 😄 You can optionally omit the brackets in some cases, as explained in this article: I guess it's also personal taste. For me, instead of having to think "do I need this here or can I omit it", it's easier to just always use it :) |
I see. Well I don't really care nor do I have much knowledge about actions, basics only. Feel free to enhance formatting :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably fine in this case, my linter doesn't show any warning :) And I also don't care enough in this case 😂
The earlier attempt seem to limit announces to repository members for some reason.
This attempt limits to the repo only, therefore forks should not be affected.
Not sure if it works, but there is only one way to find out.