Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store two additional variables to /etc/armbian-release #7156

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Aug 31, 2024

Description

New variable VENDORPRETTYNAME that can be set separately from VENDOR. And list of preinstalled EXTENSIONS.

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik igorpecovnik requested a review from a team as a code owner August 31, 2024 14:22
@github-actions github-actions bot added size/small PR with less then 50 lines Framework Framework components labels Aug 31, 2024
@igorpecovnik igorpecovnik added 11 Milestone: Fourth quarter release Needs review Seeking for review labels Aug 31, 2024
lib/functions/rootfs/distro-agnostic.sh Outdated Show resolved Hide resolved
@igorpecovnik igorpecovnik added the Ready to merge Reviewed, tested and ready for merge label Sep 1, 2024
@igorpecovnik igorpecovnik merged commit 9af94d5 into armbian:main Sep 3, 2024
@rpardini
Copy link
Member

rpardini commented Sep 6, 2024

great, "this will break" and then merge sans approval. look at the positive side, can't get worse than this.

@igorpecovnik
Copy link
Member Author

?? What in this PR will break?

@rpardini
Copy link
Member

rpardini commented Sep 7, 2024

See reviews I did above.

  • extensions can be one, two, or more, and are enabled/disabled independently of the bsp-cli. including this variable in the package contents without hashing it will cause the contents in the packages published to repo to be effectively random. Also, extensions are supposed to be independent from bsp-cli so the whole concept doesn't really make sense.
  • VENDORPRETTYNAME is simpler, a single value, but still needs hashing -- otherwise when changed won't reflect in a new package.

@igorpecovnik
Copy link
Member Author

See reviews I did above

I don't saw any reviews. Where?

Understand now what is the problem.

@rpardini
Copy link
Member

rpardini commented Sep 7, 2024

Yes. perfect. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Framework Framework components Needs review Seeking for review Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

3 participants