Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: BigTreeTech CB1 patches and edge dts #7159

Merged

Conversation

JohnTheCoolingFan
Copy link
Contributor

Description

As asked in #7127, removed the hook in board config that changed which dts file is used on edge kernel branch and changed symlink patches to actual files.

GitHub issue reference:
Jira reference number [AR-9999]

How Has This Been Tested?

  • build for bigtreetech cb1 and boot

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@JohnTheCoolingFan JohnTheCoolingFan added the Bugfix Pull request is fixing a bug label Sep 1, 2024
@github-actions github-actions bot added size/large PR with 250 lines or more Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... and removed size/large PR with 250 lines or more labels Sep 1, 2024
@JohnTheCoolingFan JohnTheCoolingFan marked this pull request as draft September 1, 2024 18:07
@github-actions github-actions bot added the size/medium PR with more then 50 and less then 250 lines label Sep 1, 2024
@JohnTheCoolingFan JohnTheCoolingFan marked this pull request as ready for review September 1, 2024 18:08
@JohnTheCoolingFan
Copy link
Contributor Author

@The-going hope I did everything right and soon I can get to improving support for edge on bigtreetech-cb1

@The-going
Copy link
Contributor

@JohnTheCoolingFan
From the point of view of the order of application of patches, yes, everything is correct now.

From the point of view of the technology of promoting patches to the new version of the kernel,
there is one inaccuracy.
Your files will be renamed automatically upon new extraction.

arm64-dts-sun50i-h616-bigtreetech-cb1-enable-emac1.patch -> ARM64-dts-sun50i-h616-BigTreeTech-CB1-Enable-EMAC1.patch
arm64-dts-sun50i-h616-bigtreetech-cb1-enable-hdmi.patch -> ARM64-dts-sun50i-h616-BigTreeTech-CB1-Enable-HDMI.patch

I have already explained why this is happening.
But there is no need to redo it here.
This is a thing of the past.

@igorpecovnik Please accept this before sunxi-6.10 is finished

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 11 Milestone: Fourth quarter release labels Sep 1, 2024
@igorpecovnik igorpecovnik merged commit 23cff91 into armbian:main Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Bugfix Pull request is fixing a bug Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines
Development

Successfully merging this pull request may close these issues.

3 participants