Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

distro-specific: systemd-resolved: don't impose 1.0.0.1 DNS server on users #7166

Merged
merged 1 commit into from
Sep 10, 2024
Merged

distro-specific: systemd-resolved: don't impose 1.0.0.1 DNS server on users #7166

merged 1 commit into from
Sep 10, 2024

Conversation

rpardini
Copy link
Member

@rpardini rpardini commented Sep 2, 2024

distro-specific: systemd-resolved: don't impose 1.0.0.1 DNS server on users

@github-actions github-actions bot added size/small PR with less then 50 lines Framework Framework components labels Sep 2, 2024
@rpardini rpardini marked this pull request as ready for review September 2, 2024 07:14
@rpardini rpardini requested a review from a team as a code owner September 2, 2024 07:14
@EvilOlaf
Copy link
Member

EvilOlaf commented Sep 2, 2024

I don't fully understand. Would this deprecate $NAMESERVER which can be set in config files?

@igorpecovnik igorpecovnik requested a review from sfx2000 September 3, 2024 11:37
@igorpecovnik igorpecovnik added 11 Milestone: Fourth quarter release Needs review Seeking for review labels Sep 3, 2024
@rpardini
Copy link
Member Author

rpardini commented Sep 6, 2024

I don't fully understand. Would this deprecate $NAMESERVER which can be set in config files?

NAMESERVER, if unset, defaults to 1.0.0.1, always -- it is used and required during image building (by replacing resolv.conf directly) but also being imposed on the runtime image since b6f018a when using systemd-networkd (eg NOT with NetworkManager).

@rpardini rpardini force-pushed the pr/distro-specific-systemd-resolved-dont-impose-1001-DNS-server-on-users branch from e25317d to 57aa41e Compare September 6, 2024 20:57
@EvilOlaf
Copy link
Member

EvilOlaf commented Sep 7, 2024

Ah. Thanks for clarification.

@rpardini rpardini force-pushed the pr/distro-specific-systemd-resolved-dont-impose-1001-DNS-server-on-users branch from 57aa41e to d88e135 Compare September 7, 2024 07:16
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Sep 10, 2024
@igorpecovnik igorpecovnik merged commit a1b1d61 into armbian:main Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpecovnik igorpecovnik igorpecovnik approved these changes

@sfx2000 sfx2000 Awaiting requested review from sfx2000

Assignees
No one assigned
Labels
11 Milestone: Fourth quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rpardini @EvilOlaf @igorpecovnik