Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub CLI GPG key #7192

Merged

Conversation

williammartin
Copy link
Contributor

@williammartin williammartin commented Sep 8, 2024

Description

I believe this updates the GPG key used for the GitHub CLI package repository with the new key as described in cli/cli#9569. I'm afraid I don't know how to test this change because I'm not familiar with the project. I'm just trying to be proactive in getting this fixed, many apologies from the GitHub CLI team 🙏

GitHub issue reference: #7186
Jira reference number AR-2483

Documentation summary for feature / change

How Has This Been Tested?

I have not really run any tests. I don't know how to validate this.

I downloaded the file from this PR and imported into my keychain to verify it was the correct key:

➜  ~ gpg --import githubcli.gpg
gpg: key 23F3D4EA75716059: public key "GitHub CLI <opensource+cli@github.com>" imported
gpg: Total number processed: 1
gpg:               imported: 1
➜  ~ gpg --list-keys
[keyboxd]
---------
pub   rsa4096 2022-09-06 [SC] [expires: 2026-09-05]
      2C6106201985B60E6C7AC87323F3D4EA75716059
uid           [ unknown] GitHub CLI <opensource+cli@github.com>
sub   rsa4096 2022-09-06 [E] [expires: 2026-09-05]

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added size/small PR with less then 50 lines Desktop Graphical user interface labels Sep 8, 2024
@williammartin
Copy link
Contributor Author

williammartin commented Sep 8, 2024

Ah, looks like a 5 minute late duplicate of #7191, closing this!

@igorpecovnik
Copy link
Member

Keep this PR. I have too many commits ;)

@williammartin williammartin reopened this Sep 8, 2024
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge Bugfix Pull request is fixing a bug 11 Milestone: Fourth quarter release labels Sep 8, 2024
@igorpecovnik igorpecovnik merged commit 0439cb2 into armbian:main Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11 Milestone: Fourth quarter release Bugfix Pull request is fixing a bug Desktop Graphical user interface Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

2 participants