rootfs: don't use the Armbian repo when building rootfs from both GHA pipelines and CLI; fixes #7123 #7313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pipelines and CLI; fixes armbian#7123 - Fixes: 7129643 -- which only set `SKIP_ARMBIAN_REPO=yes` when `rootfs` cli shortcut used - GHA artifact pipelines are generic across all artifacts, and don't use the cli shortcuts - instead, they use the `artifact` shortcut, with the `WHAT=rootfs` parameter - so in GHA pipelines `SKIP_ARMBIAN_REPO=yes` was not taking effect - rootfs artifact itself now enforces `SKIP_ARMBIAN_REPO` to be `yes` and makes it readonly - also add `SKIP_ARMBIAN_REPO` to the general change-tracking for more clarity about configs and hooks etc - add change tracking calls before/after generic artifact config adapter for even more clarity
github-actions
bot
added
Framework
igorpecovnik
added
Ready to merge
igorpecovnik
approved these changes
Sep 30, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rootfs: don't use the Armbian repo when building rootfs from both GHA pipelines and CLI; fixes #7123
SKIP_ARMBIAN_REPO=yeswhenrootfscli shortcut usedartifactshortcut, with theWHAT=rootfsparameterSKIP_ARMBIAN_REPO=yeswas not taking effectSKIP_ARMBIAN_REPOto beyesand makes it readonlySKIP_ARMBIAN_REPOto the general change-tracking for more clarity about configs and hooks etc