-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "binman" BOOT_SCENARIO to better support current Rockchip u-boot + update Rock S0 and RockPI-S to use it #7486
Conversation
support for rock-s0 is broken in uboot v2024.10
Signed-off-by: Brent Roman <brent@mbari.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not against it, but please split the BOOT_SCENARIO changes into its own PR so we can discuss it better.
Nobody will see it if it is hidden in a RockPI-S
board PR...
@rpardini |
Is this safe to merge into current upcoming release? |
Perfectly valid, thanks. I added @armbian/boards-rockchip for awareness.
This needs testing, as changes to rockchip64_common always do. I've already spotted a bug (I think) and I've not ran it yet, so I'd definitely not hurry. |
@rpardini |
Sure @brentr I didn't mean to hide anything, I just haven't had the cycles to pick and run with the changes. The bug the back of my brain saw is in line 23 of the proposed rockchip64_common file ( |
ensure that a null RKBIN_DIR env var does not override its default value
@rpardini |
Hi @brentr could you please rebase this onto |
Description
Added a new "binman" BOOT_SCENARIO to allow other Rockchip boards to use 2024.10 with without resorting to defining custom write_uboot_platform() in each board config.
Update RockPI-S and Rock S0 from u-boot v2022.04 to u-boot v2024.10 to use the new "binman" BOOT_SCENARIO as an example.
It's my hope that other Rockchip board maintainers who are using u-boot's new binman single file boot image will take advantage of this to simplify their board configs.
[GitHub issue] #7485
Jira AR-2536
Documentation summary for feature / change
How Has This Been Tested?
Checklist: