Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rk35xx-vendor: build DRM_PANEL_MIPI_DBI as builtin #7599

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

amazingfate
Copy link
Contributor

This driver will request firmware by the first compatiable string from devicetree, which is usually a device specific string not in the driver code. If this driver is built as module, it can't get loaded because only the first compatible string is used to probe driver. There is no such issue if this driver is built in kernel.

Description

ChatGPT has told me why:

Summary of Why It Works When Built-In

Device Tree Matching Is Explicit:

  • Built-in drivers use the Device Tree's compatible property directly, bypassing the modalias mechanism.

Driver Probing During Boot:

  • Built-in drivers are probed during boot for any matching devices, without relying on dynamic module loading.

modalias Irrelevance for Built-In Drivers:

  • The modalias is only used to locate and load a module. When the driver is built into the kernel, it doesn't need to be located or loaded.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

This driver will request firmware by the first compatiable string from
devicetree, which is usually a device specific string not in the driver
code. If this driver is built as module, it can't get loaded because
only the first compatible string is used to probe driver. There is no
such issue if this driver is built in kernel.
@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Dec 21, 2024
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 02 Milestone: First quarter release labels Dec 21, 2024
@amazingfate amazingfate merged commit 33dc847 into armbian:main Dec 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Milestone: First quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

2 participants