Add Samba package

[dimitry-ishenko]

This is a draft PR to make sure I am on the right track.

@igorpecovnik in #242 you have enable, disable and config options. What did you have in mind exactly?

Also, couple of issues I've noticed so far:

1. I've had issues with debconf-apt-progress not being able to uninstall samba with the following error:

Removing samba (2:4.19.5+dfsg-4ubuntu9) ...
Setting up samba-common (2:4.19.5+dfsg-4ubuntu9) ...
Can't locate object method "new" via package "Text::Iconv" (perhaps you forgot to load "Text::Iconv"?) at /usr/share/perl5/Debconf/Encoding.pm line 65, <GEN2> line 2.
dpkg: error processing package samba-common (--configure):
 installed samba-common package post-installation script subprocess returned error exit status 255
dpkg: dependency problems prevent configuration of samba-common-bin:
 samba-common-bin depends on samba-common (= 2:4.19.5+dfsg-4ubuntu9); however:
  Package samba-common is not configured yet.

dpkg: error processing package samba-common-bin (--configure):
 dependency problems - leaving unconfigured
Processing triggers for man-db (2.12.0-4build2) ...
Errors were encountered while processing:
 samba-common
 samba-common-bin
E: Sub-process /usr/bin/dpkg returned an error code (1)

Installing libtext-iconv-perl handled the error...

2. I've noticed that noticed that most (all?) packages use apt-get purge to uninstall themselves. The problem with this is that it does not uninstall dependencies. I've used apt-get autopurge instead, which add --autoremove option to remove all dangling dependent packages.

[Tearran]

Good start. The commands should be in a module.
https://github.com/armbian/configng/blob/main/tools/template/module_software_template.sh

function module_samba() {

}

[igorpecovnik]

What did you have in mind exactly?

I didn't use correct wording. II meant install / uninstall and configuration - choosing common folder as a parameter / input. We need to insert some default config. People usually export some common data folder as read only accessible without password. App download section is using /armbian/ as a common download folder. IMO that should be available by default upon enabling (installing) samba. Anything else?

About issues.

1. I haven't used Samba in years, but I assume this part should be easy to resolve. We could be looking at different install commands at Debian and Ubuntu based rootfs. I hope not, but this kind of exceptions can be handled easily when a dedicated module for this feature is made. As proposed by @Tearran too. Even we are looking at simple apt commands, we should make a module.
2. Agree. Here I wasn't sure what is best practice, so I opened another ticket [Task]: Collections of small future improvements #266 where task is to unify those procedures. I have added this there.