Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve networking guide #444

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Improve networking guide #444

merged 1 commit into from
Jul 7, 2024

Conversation

ColorfulRhino
Copy link
Contributor

  • Make more use of Markdown syntax
  • Change the yaml config names to the ones used in the build framework to avoid issues with overwritings and confusions
  • Add some links for reference
  • Add some information
  • Restructure some infos

@ColorfulRhino ColorfulRhino force-pushed the network-doc branch 2 times, most recently from b8b42da to 1acf743 Compare July 6, 2024 19:59
@ColorfulRhino
Copy link
Contributor Author

ColorfulRhino commented Jul 6, 2024 •
edited
Loading

Sorry, I did not see #443 before writing this, but the changes from that PR are basically included in this.

@ColorfulRhino ColorfulRhino force-pushed the network-doc branch 2 times, most recently from be89b33 to 64af846 Compare July 6, 2024 20:10
@ColorfulRhino
networking: Add Markdown syntax, links and more info to networking docs
490d8da 
- Make more use of Markdown syntax
- Change the yaml config names to the ones used in the build framework to avoid issues with overwritings and confusions
- Add some links for reference
@igorpecovnik
Copy link
Member

Sorry, I did not see

That's just cosmetic, removing extra tabs. I'll close it.

igorpecovnik
igorpecovnik approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@igorpecovnik igorpecovnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great write-up. l also didn't find any grammar / typo errors, hence approving it.

@igorpecovnik igorpecovnik merged commit 8f38581 into armbian:master Jul 7, 2024
@ColorfulRhino ColorfulRhino deleted the network-doc branch July 7, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpecovnik igorpecovnik igorpecovnik approved these changes

@EvilOlaf EvilOlaf Awaiting requested review from EvilOlaf

Assignees
No one assigned
Labels
enhancement ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ColorfulRhino @igorpecovnik