Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: templated customDirectory name override #98

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

TyIsI
Copy link
Contributor

@TyIsI TyIsI commented Jul 29, 2023

New customDirectory override options/arg to allow for more flexible
component directory naming.

New customDirectory override options/arg to allow for more flexible
component directory naming.
@kevinpainchaud
Copy link

Nice work! Someone to valid this PR? 🙏

@arminbro
Copy link
Owner

arminbro commented Nov 8, 2023

Thanks for the PR, @TyIsI!

I will take a closer look at your PR when I get a chance this weekend and make sure everything is working before I merge it.

@arminbro arminbro self-requested a review November 8, 2023 04:18
Copy link
Owner

@arminbro arminbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TyIsI This PR looks good!

Thank you for taking the time to add this feature.

I like the idea of having the flexibility to have custom directory names while supporting all the built-in casings out of the box.

I will merge your PR, and it should be live with the next release.

@arminbro arminbro merged commit e17a979 into arminbro:master Nov 18, 2023
Copy link

🎉 This PR is included in version 8.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants