Add a method to expose the proxy protocol destination address. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be |
Also extended the existing SourceCheck() mechanism to govern both remote and local addresses.
bboreham
force-pushed
the
expose-dstaddr
branch
from
50b4985 to
0a8c12a
Compare
|
Rebased and updated in line with your feedback. I left the two commits so it's clear who did what. |
|
LGTM! |
nathanejohnson
added a commit
to nathanejohnson/go-proxyproto
that referenced
this pull request
Oct 18, 2020
This should allow users to simulate the functionality with LocalAddr() that changed with armon#7 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternatively, we could expose it as part of
LocalAddr(), similar toRemoteAddr(). WDYT?