forked from spinnaker/kork
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'master' into feat/donateObservabilityPlugin
- Loading branch information
Showing
13 changed files
with
418 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
224 changes: 224 additions & 0 deletions
224
...rofit2/src/test/java/com/netflix/spinnaker/kork/retrofit/Retrofit2ServiceFactoryTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,224 @@ | ||
| /* | ||
| * Copyright 2025 OpsMx, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.netflix.spinnaker.kork.retrofit; | ||
|
|
||
| import static com.github.tomakehurst.wiremock.client.WireMock.aResponse; | ||
| import static com.github.tomakehurst.wiremock.client.WireMock.equalTo; | ||
| import static com.github.tomakehurst.wiremock.client.WireMock.get; | ||
| import static com.github.tomakehurst.wiremock.client.WireMock.getRequestedFor; | ||
| import static com.github.tomakehurst.wiremock.client.WireMock.stubFor; | ||
| import static com.github.tomakehurst.wiremock.client.WireMock.urlEqualTo; | ||
| import static com.github.tomakehurst.wiremock.client.WireMock.verify; | ||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertThrows; | ||
|
|
||
| import com.fasterxml.jackson.databind.ObjectMapper; | ||
| import com.github.tomakehurst.wiremock.WireMockServer; | ||
| import com.github.tomakehurst.wiremock.client.WireMock; | ||
| import com.github.tomakehurst.wiremock.core.WireMockConfiguration; | ||
| import com.netflix.spinnaker.config.DefaultServiceClientProvider; | ||
| import com.netflix.spinnaker.config.DefaultServiceEndpoint; | ||
| import com.netflix.spinnaker.config.ServiceEndpoint; | ||
| import com.netflix.spinnaker.config.okhttp3.DefaultOkHttpClientBuilderProvider; | ||
| import com.netflix.spinnaker.config.okhttp3.OkHttpClientProvider; | ||
| import com.netflix.spinnaker.kork.client.ServiceClientFactory; | ||
| import com.netflix.spinnaker.kork.client.ServiceClientProvider; | ||
| import com.netflix.spinnaker.kork.retrofit.exceptions.SpinnakerConversionException; | ||
| import com.netflix.spinnaker.kork.retrofit.exceptions.SpinnakerHttpException; | ||
| import com.netflix.spinnaker.kork.retrofit.exceptions.SpinnakerServerException; | ||
| import com.netflix.spinnaker.okhttp.OkHttpClientConfigurationProperties; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import okhttp3.Interceptor; | ||
| import okhttp3.OkHttpClient; | ||
| import okhttp3.Request; | ||
| import org.junit.jupiter.api.AfterAll; | ||
| import org.junit.jupiter.api.BeforeAll; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.boot.test.context.SpringBootTest; | ||
| import org.springframework.context.annotation.Bean; | ||
| import org.springframework.context.annotation.Configuration; | ||
| import retrofit2.Call; | ||
| import retrofit2.Response; | ||
| import retrofit2.http.GET; | ||
|
|
||
| @SpringBootTest( | ||
| webEnvironment = SpringBootTest.WebEnvironment.NONE, | ||
| classes = { | ||
| OkHttpClient.class, | ||
| OkHttpClientConfigurationProperties.class, | ||
| OkHttpClientProvider.class, | ||
| Retrofit2ServiceFactoryAutoConfiguration.class, | ||
| Retrofit2ServiceFactoryTest.Retrofit2TestConfig.class, | ||
| DefaultOkHttpClientBuilderProvider.class | ||
| }) | ||
| public class Retrofit2ServiceFactoryTest { | ||
|
|
||
| @Autowired ServiceClientProvider serviceClientProvider; | ||
|
|
||
| static int port; | ||
| static WireMockServer wireMockServer; | ||
|
|
||
| @BeforeAll | ||
| static void setUp() { | ||
| wireMockServer = new WireMockServer(WireMockConfiguration.options().dynamicPort()); | ||
| wireMockServer.start(); | ||
| port = wireMockServer.port(); | ||
| WireMock.configureFor("localhost", port); | ||
| } | ||
|
|
||
| @AfterAll | ||
| static void tearDown() { | ||
| wireMockServer.stop(); | ||
| } | ||
|
|
||
| @Test | ||
| void testRetrofit2Client() { | ||
| stubFor( | ||
| get(urlEqualTo("/test")) | ||
| .willReturn( | ||
| aResponse() | ||
| .withHeader("Content-Type", "application/json") | ||
| .withBody("{\"message\": \"success\", \"code\": 200}"))); | ||
|
|
||
| ServiceEndpoint serviceEndpoint = | ||
| new DefaultServiceEndpoint("retrofit2service", "http://localhost:" + port); | ||
| Retrofit2TestService retrofit2TestService = | ||
| serviceClientProvider.getService(Retrofit2TestService.class, serviceEndpoint); | ||
| Map<String, String> response = Retrofit2SyncCall.execute(retrofit2TestService.getSomething()); | ||
|
|
||
| assertEquals("success", response.get("message")); | ||
| } | ||
|
|
||
| @Test | ||
| void testRetrofit2ClientWithResponse() { | ||
| stubFor( | ||
| get(urlEqualTo("/test")) | ||
| .willReturn( | ||
| aResponse() | ||
| .withHeader("Content-Type", "application/json") | ||
| .withBody("{\"message\": \"success\"}"))); | ||
|
|
||
| ServiceEndpoint serviceEndpoint = | ||
| new DefaultServiceEndpoint("retrofit2service", "http://localhost:" + port); | ||
| Retrofit2TestService retrofit2TestService = | ||
| serviceClientProvider.getService(Retrofit2TestService.class, serviceEndpoint); | ||
| Response<Map<String, String>> response = | ||
| Retrofit2SyncCall.executeCall(retrofit2TestService.getSomething()); | ||
| assertEquals(200, response.code()); | ||
| assertEquals("application/json", response.headers().get("Content-Type")); | ||
| assertEquals("success", response.body().get("message")); | ||
| } | ||
|
|
||
| @Test | ||
| void testRetrofit2Client_withInterceptor() { | ||
|
|
||
| Interceptor interceptor = | ||
| chain -> { | ||
| Request originalRequest = chain.request(); | ||
| Request modifiedRequest = | ||
| originalRequest.newBuilder().header("Authorization", "Bearer my-token").build(); | ||
| return chain.proceed(modifiedRequest); | ||
| }; | ||
|
|
||
| stubFor( | ||
| get(urlEqualTo("/test")) | ||
| .willReturn( | ||
| aResponse() | ||
| .withHeader("Content-Type", "application/json") | ||
| .withBody("{\"message\": \"success\", \"code\": 200}"))); | ||
|
|
||
| ServiceEndpoint serviceEndpoint = | ||
| new DefaultServiceEndpoint("retrofit2service", "http://localhost:" + port); | ||
| Retrofit2TestService retrofit2TestService = | ||
| serviceClientProvider.getService( | ||
| Retrofit2TestService.class, serviceEndpoint, new ObjectMapper(), List.of(interceptor)); | ||
| Retrofit2SyncCall.execute(retrofit2TestService.getSomething()); | ||
|
|
||
| verify( | ||
| getRequestedFor(urlEqualTo("/test")) | ||
| .withHeader("Authorization", equalTo("Bearer my-token"))); | ||
| } | ||
|
|
||
| @Test | ||
| void testRetrofit2Client_withHttpException() { | ||
| stubFor( | ||
| get(urlEqualTo("/test")) | ||
| .willReturn( | ||
| aResponse() | ||
| .withHeader("Content-Type", "application/json") | ||
| .withStatus(400) | ||
| .withBody("{\"message\": \"error\"}"))); | ||
|
|
||
| ServiceEndpoint serviceEndpoint = | ||
| new DefaultServiceEndpoint("retrofit2service", "http://localhost:" + port); | ||
|
|
||
| Retrofit2TestService retrofit2TestService = | ||
| serviceClientProvider.getService(Retrofit2TestService.class, serviceEndpoint); | ||
|
|
||
| SpinnakerHttpException exception = | ||
| assertThrows( | ||
| SpinnakerHttpException.class, | ||
| () -> Retrofit2SyncCall.executeCall(retrofit2TestService.getSomething())); | ||
| assertEquals(400, exception.getResponseCode()); | ||
| assertEquals( | ||
| "Status: 400, Method: GET, URL: http://localhost:" + port + "/test, Message: error", | ||
| exception.getMessage()); | ||
| } | ||
|
|
||
| @Test | ||
| void testRetrofit2Client_withConversionException() { | ||
| stubFor( | ||
| get(urlEqualTo("/test")) | ||
| .willReturn( | ||
| aResponse() | ||
| .withHeader("Content-Type", "application/json") | ||
| .withBody("{\"message\": \"incorrect json}"))); | ||
|
|
||
| ServiceEndpoint serviceEndpoint = | ||
| new DefaultServiceEndpoint("retrofit2service", "http://localhost:" + port); | ||
|
|
||
| Retrofit2TestService retrofit2TestService = | ||
| serviceClientProvider.getService(Retrofit2TestService.class, serviceEndpoint); | ||
|
|
||
| SpinnakerServerException exception = | ||
| assertThrows( | ||
| SpinnakerConversionException.class, | ||
| () -> Retrofit2SyncCall.executeCall(retrofit2TestService.getSomething())); | ||
| assertEquals( | ||
| "Failed to process response body: Unexpected end-of-input: was expecting closing quote for a string value\n" | ||
| + " at [Source: (okhttp3.ResponseBody$BomAwareReader); line: 1, column: 29]", | ||
| exception.getMessage()); | ||
| } | ||
|
|
||
| @Configuration | ||
| public static class Retrofit2TestConfig { | ||
|
|
||
| @Bean | ||
| public ServiceClientProvider serviceClientProvider( | ||
| List<ServiceClientFactory> serviceClientFactories) { | ||
| return new DefaultServiceClientProvider(serviceClientFactories, new ObjectMapper()); | ||
| } | ||
| } | ||
|
|
||
| public interface Retrofit2TestService { | ||
|
|
||
| @GET("test") | ||
| Call<Map<String, String>> getSomething(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.