Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build with 8.1.0alpha2 #54

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Conversation

remicollet
Copy link
Contributor

error_filename changed from const char * to zend_string *

/dev/shm/BUILD/php81-php-pecl-memprof-3.0.1/NTS/memprof.c: In function 'zm_startup_memprof':
/dev/shm/BUILD/php81-php-pecl-memprof-3.0.1/NTS/memprof.c:1136:20: warning: assignment to 'void (*)(int,  const char *, const uint32_t,  zend_string *)' {aka 'void (*)(int,  const char *, const unsigned int,  struct _zend_string *)'} from incompatible pointer type 'void (*)(int,  zend_string *, const uint32_t,  zend_string *)' {aka 'void (*)(int,  struct _zend_string *, const unsigned int,  struct _zend_string *)'} [-Wincompatible-pointer-types]
 1136 |  old_zend_error_cb = zend_error_cb;
      |                    ^
/dev/shm/BUILD/php81-php-pecl-memprof-3.0.1/NTS/memprof.c:1137:16: warning: assignment to 'void (*)(int,  zend_string *, const uint32_t,  zend_string *)' {aka 'void (*)(int,  struct _zend_string *, const unsigned int,  struct _zend_string *)'} from incompatible pointer type 'void (*)(int,  const char *, const uint32_t,  zend_string *)' {aka 'void (*)(int,  const char *, const unsigned int,  struct _zend_string *)'} [-Wincompatible-pointer-types]
 1137 |  zend_error_cb = memprof_zend_error_cb;
      |                ^

I also change all ZEND_MODULE_API_NO to PHP_VERSION_ID which seems more legible

@arnaud-lb arnaud-lb merged commit afda266 into arnaud-lb:v3 Jul 2, 2021
@arnaud-lb
Copy link
Owner

Thanks @remicollet

I will add 8.1 to the checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants