Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 compatibility #474

Closed
ruudk opened this issue Nov 13, 2021 · 0 comments · Fixed by #467
Closed

PHP 8.1 compatibility #474

ruudk opened this issue Nov 13, 2021 · 0 comments · Fixed by #467

Comments

@ruudk
Copy link
Contributor

ruudk commented Nov 13, 2021

When installing rdkafka from source (5.x branch) on PHP 8.1 RC6 I'm getting these deprecations:

#15 3.020 PHP Deprecated:  Return type of RdKafka\Metadata\Collection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0
#15 3.020 PHP Deprecated:  Return type of RdKafka\Metadata\Collection::current() should either be compatible with Iterator::current(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0
#15 3.020 PHP Deprecated:  Return type of RdKafka\Metadata\Collection::next() should either be compatible with Iterator::next(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0
#15 3.020 PHP Deprecated:  Return type of RdKafka\Metadata\Collection::key() should either be compatible with Iterator::key(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0
#15 3.020 PHP Deprecated:  Return type of RdKafka\Metadata\Collection::valid() should either be compatible with Iterator::valid(): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0
#15 3.020 PHP Deprecated:  Return type of RdKafka\Metadata\Collection::rewind() should either be compatible with Iterator::rewind(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in Unknown on line 0

Please merge #472 so that we can try to fix this.

@nick-zh nick-zh linked a pull request Nov 14, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant