Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.1 RC6 to CI #472

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Add PHP 8.1 RC6 to CI #472

merged 1 commit into from
Nov 15, 2021

Conversation

ruudk
Copy link
Contributor

@ruudk ruudk commented Nov 8, 2021

No description provided.

@ruudk
Copy link
Contributor Author

ruudk commented Nov 13, 2021

@nick-zh Shall we merge this to prepare for PHP 8.1?

@ruudk ruudk changed the title Add PHP 8.1 RC5 to CI Add PHP 8.1 RC6 to CI Nov 13, 2021
@ruudk ruudk mentioned this pull request Nov 13, 2021
@arnaud-lb arnaud-lb mentioned this pull request Nov 15, 2021
@arnaud-lb
Copy link
Owner

Thanks @ruudk

Could you rebase on 5.x ? I've tried doing it but the build does not pass: https://github.com/arnaud-lb/php-rdkafka/runs/4209963535?check_suite_focus=true

@ruudk
Copy link
Contributor Author

ruudk commented Nov 15, 2021

@arnaud-lb Done, please approve the workflow (you can disable this btw)

@arnaud-lb
Copy link
Owner

Thanks @ruudk

I've disabled the approval requirement

The build is failing, I think it's because there is no [[ in sh

@ruudk
Copy link
Contributor Author

ruudk commented Nov 15, 2021

@arnaud-lb Seems to be working now 🎉 Only 1 test failure, not sure how to solve that.

@arnaud-lb arnaud-lb merged commit 5fbeeca into arnaud-lb:5.x Nov 15, 2021
@arnaud-lb
Copy link
Owner

Thanks!

I will fix the test separately

@ruudk ruudk deleted the patch-1 branch November 15, 2021 14:51
@arnaud-lb
Copy link
Owner

Unfortunately the error shows that some changes will be necessary around arginfos to support PHP 8.1. I've created an issue, help welcome :) #479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants