Skip to content

Commit

Permalink
(Hooks) Generalise the extraction of plugin variables into utilities.js
Browse files Browse the repository at this point in the history
  • Loading branch information
@dpa99c
dpa99c committed Sep 16, 2020
1 parent 5118b1d commit a4e09c9
Show file tree
Hide file tree
Showing 2 changed files with 101 additions and 80 deletions.
122 changes: 44 additions & 78 deletions scripts/after_prepare.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,95 +11,61 @@ var fs = require('fs');
var path = require("path");
var Utilities = require("./lib/utilities");

var appName = Utilities.getAppName();
var appName;
var pluginVariables = {};

var IOS_DIR = 'platforms/ios';
var ANDROID_DIR = 'platforms/android';
var PLUGIN_ID = 'cordova-plugin-firebasex';

var PLATFORM = {
IOS: {
dest: IOS_DIR + '/' + appName + '/Resources/GoogleService-Info.plist',
src: [
'GoogleService-Info.plist',
IOS_DIR + '/www/GoogleService-Info.plist',
'www/GoogleService-Info.plist'
],
appPlist: IOS_DIR + '/' + appName + '/'+appName+'-Info.plist',
entitlementsDebugPlist: IOS_DIR + '/' + appName + '/Entitlements-Debug.plist',
entitlementsReleasePlist: IOS_DIR + '/' + appName + '/Entitlements-Release.plist',
},
ANDROID: {
dest: ANDROID_DIR + '/app/google-services.json',
src: [
'google-services.json',
ANDROID_DIR + '/assets/www/google-services.json',
'www/google-services.json',
ANDROID_DIR + '/app/src/main/google-services.json'
],
colorsXml:{
src: './plugins/' + Utilities.getPluginId() +'/src/android/colors.xml',
target: ANDROID_DIR + '/app/src/main/res/values/colors.xml'
var PLUGIN_ID;

var PLATFORM;

var setupEnv = function(){
appName = Utilities.getAppName();
PLUGIN_ID = Utilities.getPluginId();
PLATFORM = {
IOS: {
dest: IOS_DIR + '/' + appName + '/Resources/GoogleService-Info.plist',
src: [
'GoogleService-Info.plist',
IOS_DIR + '/www/GoogleService-Info.plist',
'www/GoogleService-Info.plist'
],
appPlist: IOS_DIR + '/' + appName + '/' + appName + '-Info.plist',
entitlementsDebugPlist: IOS_DIR + '/' + appName + '/Entitlements-Debug.plist',
entitlementsReleasePlist: IOS_DIR + '/' + appName + '/Entitlements-Release.plist',
},
ANDROID: {
dest: ANDROID_DIR + '/app/google-services.json',
src: [
'google-services.json',
ANDROID_DIR + '/assets/www/google-services.json',
'www/google-services.json',
ANDROID_DIR + '/app/src/main/google-services.json'
],
colorsXml: {
src: './plugins/' + Utilities.getPluginId() + '/src/android/colors.xml',
target: ANDROID_DIR + '/app/src/main/res/values/colors.xml'
}
}
}
};
};
}

module.exports = function(context){
//get platform from the context supplied by cordova
var platforms = context.opts.platforms;
Utilities.setContext(context);
setupEnv();

var parsePluginVariables = function(){
// Parse plugin.xml
var plugin = Utilities.parsePluginXml();
var prefs = [];
if(plugin.plugin.preference){
prefs = prefs.concat(plugin.plugin.preference);
}
plugin.plugin.platform.forEach(function(platform){
if(platform.preference){
prefs = prefs.concat(platform.preference);
}
});
prefs.forEach(function(pref){
if (pref._attributes){
pluginVariables[pref._attributes.name] = pref._attributes.default;
}
});

// Parse config.xml
var config = Utilities.parseConfigXml();
(config.widget.plugin ? [].concat(config.widget.plugin) : []).forEach(function(plugin){
(plugin.variable ? [].concat(plugin.variable) : []).forEach(function(variable){
if((plugin._attributes.name === PLUGIN_ID || plugin._attributes.id === PLUGIN_ID) && variable._attributes.name && variable._attributes.value){
pluginVariables[variable._attributes.name] = variable._attributes.value;
}
});
});

// Parse package.json
var packageJSON = Utilities.parsePackageJson();
if(packageJSON.cordova && packageJSON.cordova.plugins){
for(const pluginId in packageJSON.cordova.plugins){
if(pluginId === PLUGIN_ID){
for(const varName in packageJSON.cordova.plugins[pluginId]){
var varValue = packageJSON.cordova.plugins[pluginId][varName];
pluginVariables[varName] = varValue;
}
}
}
}
pluginVariables = Utilities.parsePluginVariables();

// set platform key path from plugin variable
if (pluginVariables.ANDROID_FIREBASE_CONFIG_FILEPATH) PLATFORM.ANDROID.src = [pluginVariables.ANDROID_FIREBASE_CONFIG_FILEPATH];
if (pluginVariables.IOS_FIREBASE_CONFIG_FILEPATH) PLATFORM.IOS.src = [pluginVariables.IOS_FIREBASE_CONFIG_FILEPATH];
};

module.exports = function (context) {
if(pluginVariables.ANDROID_FIREBASE_CONFIG_FILEPATH) PLATFORM.ANDROID.src = [pluginVariables.ANDROID_FIREBASE_CONFIG_FILEPATH];
if(pluginVariables.IOS_FIREBASE_CONFIG_FILEPATH) PLATFORM.IOS.src = [pluginVariables.IOS_FIREBASE_CONFIG_FILEPATH];

//get platform from the context supplied by cordova
var platforms = context.opts.platforms;
parsePluginVariables();

// Copy key files to their platform specific folders
if (platforms.indexOf('android') !== -1 && Utilities.directoryExists(ANDROID_DIR)) {
if(platforms.indexOf('android') !== -1 && Utilities.directoryExists(ANDROID_DIR)){
Utilities.log('Preparing Firebase on Android');
Utilities.copyKey(PLATFORM.ANDROID);

Expand Down Expand Up @@ -152,7 +118,7 @@ module.exports = function (context) {
}
}

if (platforms.indexOf('ios') !== -1 && Utilities.directoryExists(IOS_DIR)){
if(platforms.indexOf('ios') !== -1 && Utilities.directoryExists(IOS_DIR)){
Utilities.log('Preparing Firebase on iOS');
Utilities.copyKey(PLATFORM.IOS);

Expand Down
59 changes: 57 additions & 2 deletions scripts/lib/utilities.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ var fs = require('fs');
var path = require("path");
var parser = require('xml-js');

var _configXml, _pluginXml;
var _configXml, _pluginXml, _context, _pluginVariables;

var Utilities = {};

Expand All @@ -21,6 +21,10 @@ fs.ensureDirSync = function(dir){
}
};

Utilities.setContext = function(context){
_context = context;
};

Utilities.parsePackageJson = function(){
return JSON.parse(fs.readFileSync(path.resolve('./package.json')));
};
Expand Down Expand Up @@ -59,7 +63,58 @@ Utilities.getAppName = function(){
* The ID of the plugin; this should match the ID in plugin.xml.
*/
Utilities.getPluginId = function(){
return "cordova-plugin-firebasex";
// if(!_context) throw "Cannot retrieve plugin ID as hook context is not set";
return _context.opts.plugin.id;
};

Utilities.parsePluginVariables = function(){
if(_pluginVariables) return _pluginVariables;

var pluginVariables = {};

// Parse plugin.xml
var plugin = Utilities.parsePluginXml();
var prefs = [];
if(plugin.plugin.preference){
prefs = prefs.concat(plugin.plugin.preference);
}
if(typeof plugin.plugin.platform.length === 'undefined') plugin.plugin.platform = [plugin.plugin.platform];
plugin.plugin.platform.forEach(function(platform){
if(platform.preference){
prefs = prefs.concat(platform.preference);
}
});
prefs.forEach(function(pref){
if (pref._attributes){
pluginVariables[pref._attributes.name] = pref._attributes.default;
}
});

// Parse config.xml
var config = Utilities.parseConfigXml();
(config.widget.plugin ? [].concat(config.widget.plugin) : []).forEach(function(plugin){
(plugin.variable ? [].concat(plugin.variable) : []).forEach(function(variable){
if((plugin._attributes.name === Utilities.getPluginId() || plugin._attributes.id === Utilities.getPluginId()) && variable._attributes.name && variable._attributes.value){
pluginVariables[variable._attributes.name] = variable._attributes.value;
}
});
});

// Parse package.json
var packageJSON = Utilities.parsePackageJson();
if(packageJSON.cordova && packageJSON.cordova.plugins){
for(const pluginId in packageJSON.cordova.plugins){
if(pluginId === Utilities.getPluginId()){
for(const varName in packageJSON.cordova.plugins[pluginId]){
var varValue = packageJSON.cordova.plugins[pluginId][varName];
pluginVariables[varName] = varValue;
}
}
}
}

_pluginVariables = pluginVariables;
return pluginVariables;
};

Utilities.copyKey = function(platform){
Expand Down

0 comments on commit a4e09c9

Please sign in to comment.