Supporting cordova-cli@9 or cordova-lib@9

[sagrawal31]

As per cordova-lib@9, the requireCordovaModule can only be used to get the cordova-* dependency. This PR is to support that change.

For more info, apache/cordova-lib#706

[ilyakamens]

Would love for this to be merged.

Edit: I've forked it and made the same change in the meantime.

[forgr-owner]

Would love it too !

[mismith]

@sagrawal31 can you get the build passing?

[sagrawal31]

I’ll try.

On Wed, 3 Apr 2019 at 8:23 AM, Murray Smith ***@***.***> wrote: @sagrawal31 <https://github.com/sagrawal31> can you get the build passing? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1034 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABuI4jp56Ptjqs8HzN5EH1osIKxk5ENtks5vdBelgaJpZM4cNGkF> .

-- Thanks, Shashank Agrawal Co-Founder & CTO Wiz Panda Techno Solutions

…

-- DISCLAIMER: The information in this message is confidential and may be legally privileged. It is intended solely for the addressee. Access to this message by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, or distribution of the message, or any action or omission taken by you in reliance on it, is prohibited and may be unlawful. Please immediately contact the sender if you have received this message in error. Further, this e-mail may contain viruses and all reasonable precaution to minimize the risk arising there from is taken by Wiz Panda. Wiz Panda is not liable for any damage sustained by you as a result of any virus in this e-mail. All applicable virus checks should be carried out by you before opening this e-mail or any attachment thereto. Thank you - Wiz Panda Techno Solutions Private Limited.

[sagrawal31]

@mismith I fixed the Travis build. I think, all of them was from before this MR.

[mismith]

Nice work! @arnesson could this be merged now?

[BobCashStory]

i tryed your with cordova plugin add https://github.com/wizpanda/cordova-plugin-firebase pr and it work well !

[felipeclopes]

Is this what made the build pass? If yes, I'll submit a separate PR with this fix, so all the broken PRs would start passing after rebasing.

[sagrawal31]

Not really, all but yes, it did fixed a few test cases. Since the cordova & platform version passed to this script from the parent script are same hence there was no point reinstalling it again so I commented out that. But I would love to see the detailed error when this script was trying to install the same cordova & platform.

[sagrawal31]

I would also love to help you on rebasing PRs & getting them merged which are good to go because I saw various good PRs

[forgr-owner]

how can we go forward ?

[sagrawal31]

@felipeclopes can tell anything

[felipeclopes]

I'm not really sure hot to proceed. It seems that the first step would be to try to fix the test cases that are broken. If you look at the list of PRs to merge, the only ones passing are the ones who removed the tests for older Cordova versions and this one.

Maybe a separate PR just with this fix of the build cold help the other PRs to rebase and get a green status on the build system.

[sagrawal31]

In my thinking, we can start with merging this branch to master then start rebasing other PR with master so most of the PRs will by default pass

[sagrawal31]

@felipeclopes any update? I'll still suggest to move forward with this

[pcova2099]

Hi, I installed the plugin today (2019-04-15) but the error still happening (Failed to install 'cordova-plugin-firebase': CordovaError: Using "requireCordovaModule" to load non-cordova module "xcode" is not supported. Instead, add this module to your dependencies and use regular "require" to load it.)

    <plugin name="cordova-plugin-firebase" spec="https://github.com/arnesson/cordova-plugin-firebase" />
    <engine name="android" spec="7.1.4" />
    <engine name="ios" spec="4.5.5" />

Version 2.0.5 was installed by cordova

[forgr-owner]

@pcova2099 it's not merged that why, if you want to make it work before merge, use this cordova plugin add https://github.com/wizpanda/cordova-plugin-firebase

[pcova2099]

I´ve got this error with

cordova plugin add https://github.com/wizpanda/cordova-plugin-firebase

Installing "cordova-plugin-firebase" for ios
Failed to install 'cordova-plugin-firebase': Error: Cannot find module 'xcode'

Ionic:

   ionic (Ionic CLI)  : 4.4.0 (C:\Users\pcova\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework    : ionic-angular 3.9.3
   @ionic/app-scripts : 3.2.1

Cordova:

   cordova (Cordova CLI) : 8.1.2 (cordova-lib@8.1.1)
   Cordova Platforms     : ios 4.5.5
   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 3.1.2, (and 5 other plugins)

System:

 (C:\Program Files (x86)\Android\android-sdk)
   NodeJS            : v8.11.1 (C:\Program Files (x86)\nodejs\node.exe)
   npm               : 5.6.0
   OS                : Windows 10

[sagrawal31]

@pcova2099 you need to run npm i xcode --save-dev in your project as a temporary workaround as I have mentioned here

[gdespiritorflex]

+1

[hiepxanh]

hello sir, I see this PR along time, can I ask, when this will be merge?

[remisture]

Is this project dead?

[paulsmith47]

I am also waiting for this PR to be merged will this happen any time soon?

[nascarjake]

This is still marked open and I'm still getting the error, assuming this isn't merged yet. Do we know when it will be? Have yet to try the work around. Wanted to know how close the merge was.

[ryanmtaylor]

@nascarjake a lot of people have moved to https://github.com/wizpanda/cordova-plugin-firebase-lib or https://github.com/dpa99c/cordova-plugin-firebasex