Fixed #374 issue: colors.xml resource already exists on android insta… #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Even though not having a pretty fix for it, I'm assuming a |
|
@soumak77, could you check what happens with the build ? I think that it is an important fix to avoid build problems on Android and especially when you are also using other plugins in your project. |
|
@rpanadero thanks for the PR. 👍 |
|
Would love if this got merged. |
ilyakamens
added a commit
to propelinc/cordova-plugin-firebase
that referenced
this pull request
Apr 10, 2019
See here: arnesson#938
rammie
pushed a commit
to propelinc/cordova-plugin-firebase
that referenced
this pull request
Apr 21, 2019
See here: arnesson#938
…irebase.google.com/support/release-notes/android#update_-_april_05_2019) which removed deprecated API features causing Android build failures. Resolves #1057.
…-issue' into fix-colors--res-conflict
rammie
pushed a commit
to propelinc/cordova-plugin-firebase
that referenced
this pull request
May 24, 2019
See here: arnesson#938
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue is described here: #374
The applied change just renames the
colors.xmlfile to avoid conflicts when the plugin is installed on an Android Cordova project. Take into account that other plugins could provide the same file so that the compilation would fail if this plugin and another one try to provide the "same" resource file.As this change is minor, I would glad that you merge this change to avoid having a fork from this repository.
Testing
This fix has been tested by trying to install the plugin in a project which has several plugins.
Thank you in advance,