Check nested iframes for video elements #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added a function which checks the iframes on a page for same source policy and then checks if they have a video in them. It's even potentially recursive if the site uses nested iframes. The existing video element locating is used first & all other functionality should be left working as it was previously. That being said, I haven't yet tested this code within the safari extension itself. Here's an example of a site using nested iframes for their self-hosted video element: https://www.giantbomb.com/chat/
|
Not sure if it is related, but I noticed that the videos on PBS also tend to be wrapped in an iframe and thus unfortunately don't work with PiPifier. I'm guessing this is to do with most iframe videos? Example here: http://www.pbs.org/the-farthest/video/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a function which checks the iframes on a page for same source policy and then checks if they have a video in them. It's even potentially recursive if the site uses nested iframes. The existing video element locating is used first & all other functionality should be left working as it was previously. That being said, I haven't yet tested this code within the safari extension itself.
Here's an example of a site using nested iframes for their self-hosted video element: https://www.giantbomb.com/chat/