Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard select then divide bug #1981

Closed
mgreminger opened this issue May 23, 2023 · 1 comment
Closed

Keyboard select then divide bug #1981

mgreminger opened this issue May 23, 2023 · 1 comment
Assignees
@arnog
Labels
bug

Comments

@mgreminger
Copy link
Contributor

Description

Many thanks for the recent fixes. I'm getting closer to getting 0.94.3 to pass my test suite but there are a couple of tests that are still failing compared to the slightly modified 0.93 version I'm currently running in production (I've backported the iframe fix to 0.93 for my production site).

Typing a numerator and then selecting it by using Shift+LeftArrow and then typing divide works correctly. However, when typing the denominator, the first key press results in an error and no input into the math-field. See the screen recording below for details.

Screen.Recording.2023-05-23.at.9.30.34.AM.mov

Additionally, 0.94.3 is no longer working in cross origin iFrames, I'm working a reproduction for this one and will submit it as a separate issue.

Environment

MathLive version
0.94.3

Operating System
macOS and Linux

Browser
Chrome, Safari, and Firefox
@arnog arnog closed this as completed in 56cec2b May 23, 2023
@arnog arnog self-assigned this May 23, 2023
@arnog arnog added the bug label May 23, 2023
@arnog
Copy link
Owner

arnog commented May 23, 2023

Thanks for reporting this. Fixed now. Let me know about the iframes issue...

mgreminger added a commit to mgreminger/mathlive that referenced this issue May 23, 2023
@mgreminger
tests: add regression tests
76836e5 
Adds regression tests for arnog#1975, arnog#1978, and arnog#1981

Also skip webkit iframe test in CI only since this test fails most of the time in CI even though it passes locally
@mgreminger mgreminger mentioned this issue May 23, 2023
Merged
arnog pushed a commit that referenced this issue May 23, 2023
@mgreminger
Add regression tests (#1983)
7de55d8 
* tests: add regression tests

Adds regression tests for #1975, #1978, and #1981

Also skip webkit iframe test in CI only since this test fails most of the time in CI even though it passes locally

* tests: add text mode serialization regression test
helio3197 pushed a commit to helio3197/mathlive that referenced this issue May 26, 2023
@arnog @helio3197
fix: fixed arnog#1981
b9e8936
helio3197 pushed a commit to helio3197/mathlive that referenced this issue May 26, 2023
@mgreminger @helio3197
Add regression tests (arnog#1983)
ce03052 
* tests: add regression tests

Adds regression tests for arnog#1975, arnog#1978, and arnog#1981

Also skip webkit iframe test in CI only since this test fails most of the time in CI even though it passes locally

* tests: add text mode serialization regression test
@a-gt a-gt mentioned this issue May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arnog arnog

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arnog @mgreminger