-
-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-Origin iFrame Bug #1982
Comments
I'm not sure I have a complete fix. AFAICT the CodePen you have cannot fully work, since the cross-origin policy correctly prevents access between the frame and the host document. However, I have implemented some resilience so that no runtime error will be generated. The virtual keyboard will not be functional in the embedded frame in this situation, though. |
Thanks for the fix, I'll try it out. Yes, you're correct, the virtual keyboard needs same origin to work. I just need the physical keyboard input to work. I'll attempt to create a test for this as well. |
Yes, that did the trick, thanks! I just submitted a pull request to add a cross-origin iframe test that uses the physical keyboard. This is in addition to the current same-origin iframe test that uses the virtual keyboard. |
OK, great. Thanks for the tests! |
* tests: add cross-origin iframe test Also, move iframe tests to their own page to prevent nested iframes. same-origin iframe test uses virtual keyboard and cross-origin iframe test uses phyiscal test * tests: fix cross-origin iframe test
Description
When a page with a math-field element is embedded in an iframe on a site at a different origin, keyboard input into the math-field does not work and generates console errors. I've created a minimum reproduction on code-pen here. The issue is also shown in the screen recording below:
Screen.Recording.2023-05-23.at.9.58.10.AM.mov
MathLive version
0.94.3
Operating System
All
Browser
All
The text was updated successfully, but these errors were encountered: