Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Holding Shift on Windows physical keyboard rapidly toggles Shift on virtual MathLive keyboard #2064

Closed
oscarhermoso opened this issue Jul 20, 2023 · 0 comments · Fixed by #2069
Closed

Holding Shift on Windows physical keyboard rapidly toggles Shift on virtual MathLive keyboard #2064

oscarhermoso opened this issue Jul 20, 2023 · 0 comments · Fixed by #2069
Labels
bug

Comments

@oscarhermoso
Copy link
Contributor

oscarhermoso commented Jul 20, 2023 •
edited
Loading

Description

On Windows, holding Shift with a physical keyboard rapidly toggles the Shift modifier on MathLive keyboard

Steps to Reproduce

On MS Windows

  1. Visit MathLive Demo at https://cortexjs.io/mathlive/demo/
  2. Hold Shift

Actual Behavior

Keyboard rapidly toggles, see gif below

mathlive-shift

Expected Behavior

Holding Shift should enable "once" when held, until it is released, and then ideally return to an unmodified keyboard.

(although I also understand it may be intended functionality to remain "toggled on" once released)

Environment

MathLive version on website 2023-20-07, assume version 0.94.7

Windows 10 Home, v10.0.19045 Build 19045

Both Chrome 115.0.5790.99 (64-bit) and Firefox Version 115.0.2 (64-bit)
@oscarhermoso oscarhermoso changed the title Holding Shift on Windows rapidly toggles Shift on virtual MathLive keyboard Holding Shift on Windows physical keyboard rapidly toggles Shift on virtual MathLive keyboard Jul 20, 2023
@arnog arnog added the bug label Jul 20, 2023
oscarhermoso added a commit to kedyou/mathlive that referenced this issue Jul 21, 2023
@oscarhermoso
Fix holding shift on Windows firing rapidly (arnog#2064)
9946122
oscarhermoso added a commit to kedyou/mathlive that referenced this issue Jul 21, 2023
@oscarhermoso
fix: Fix holding shift on Windows firing rapidly (arnog#2064)
5acc4e0
@oscarhermoso oscarhermoso mentioned this issue Jul 21, 2023
Merged
arnog pushed a commit that referenced this issue Jul 21, 2023
@oscarhermoso
feat: Press/hold Shift modifier instead of toggle when using with p…
55ab74b 
…hysical keyboard, and fix rapid toggling of `Shift` on Windows (#2069)

* feat: `Shift` modifier with physical keyboard (Fixes #2065)

* fix: Fix holding shift on Windows firing rapidly (#2064)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@arnog @oscarhermoso