Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: shields: Add X-NUCLEO-IDB05A1 #16

Closed
wants to merge 0 commits into from
Closed

boards: shields: Add X-NUCLEO-IDB05A1 #16

wants to merge 0 commits into from

Conversation

yboutreux
Copy link
Collaborator

@yboutreux yboutreux commented Jun 20, 2019 •
edited
Loading

Add STMicroelectronics BLE shield X-NUCLEO-IDB05A1

Signed-off-by: Yaël Boutreux yael.boutreux@st.com

@yboutreux yboutreux requested a review from erwango as a code owner June 20, 2019 14:30
@yboutreux yboutreux requested review from arnopo and atorgue June 20, 2019 14:31
erwango
erwango requested changes Jun 21, 2019
View reviewed changes
Copy link
Collaborator

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
Split the shield and the board commit, so we don't have to wait for dependency.
Then go for zephyr upstream.

Question: Have you been able to test the shield with any board other than MP1?

arnopo
arnopo reviewed Jun 21, 2019
View reviewed changes
boards/arm/stm32mp157c_dk2/arduino_r3_connector.dtsi Outdated Show resolved Hide resolved
boards/shields/x_nucleo_idb05a1/doc/index.rst Outdated

X-NUCLEO-IDB05A1 provides a SPBTLE-RF chip with the following key features:


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra line to suppress, to check in whole file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra-lines removed

boards/shields/x_nucleo_idb05a1/doc/index.rst Outdated Show resolved Hide resolved
boards/shields/x_nucleo_idb05a1/x_nucleo_idb05a1.overlay Outdated Show resolved Hide resolved
@yboutreux
Copy link
Collaborator Author

Great!
Split the shield and the board commit, so we don't have to wait for dependency.
Then go for zephyr upstream.

Question: Have you been able to test the shield with any board other than MP1?

Not yet, I only checked with the MP1, tell me if you want me to check with something else and I'll try some basic samples BLE samples :)

@yboutreux yboutreux force-pushed the upstream_add_idb05a1 branch 2 times, most recently from 1b28e26 to 9733ab0 Compare June 24, 2019 06:59
@yboutreux
Copy link
Collaborator Author

yboutreux commented Jun 24, 2019 •
edited
Loading

@erwango what about this :
#16 : no dependencies, ready to upstream
#17 : upstreamed zephyrproject-rtos#17035
#15 : dependent of R3 connector, wait for R3 to be added, then add the SPI node to the Arduino R3 mapping

@yboutreux yboutreux force-pushed the upstream_add_idb05a1 branch from 9733ab0 to 929078d Compare June 26, 2019 07:07
@yboutreux
Copy link
Collaborator Author

yboutreux commented Jun 26, 2019 •
edited
Loading

Updated with more informations: specified which test passed on which boards.
Added disco_l475_iot1.conf as a dummy to document BlueNRG-MS chip 16MHz know limitation.

@erwango we might want to wait the SPI and Arduino-R3 connector adding for stm32mp157c_dk2 on Zephyr before adding the second commit related to stm32mp157c-dk2 ?

@yboutreux yboutreux requested review from erwango and arnopo June 26, 2019 08:20
@yboutreux yboutreux force-pushed the upstream_add_idb05a1 branch 4 times, most recently from 0c67e21 to 41c251e Compare July 3, 2019 11:12
@yboutreux
Copy link
Collaborator Author

Waiting status about zephyrproject-rtos#17310 to go further

erwango
erwango requested changes Jul 4, 2019
View reviewed changes
boards/shields/x_nucleo_idb05a1/boards/disco_l475_iot1.conf Outdated
@@ -0,0 +1 @@
CONFIG_SPI_1=y
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, not sure it makes sense to enabled this shield on this board.

Copy link
Collaborator Author

@yboutreux yboutreux Jul 4, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, indeed this is a bit twisted... Will be removed

boards/shields/x_nucleo_idb05a1/boards/stm32mp157c_dk2.conf Outdated
@@ -0,0 +1 @@
CONFIG_SPI_4=y
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If SPI_4 is arduino SPI, I'd expect it to be enabled conditionally if SPI is enabled

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct this is Arduino SPI, will be removed

@yboutreux yboutreux force-pushed the upstream_add_idb05a1 branch from 41c251e to 87eeb0b Compare July 4, 2019 08:41
@yboutreux
Copy link
Collaborator Author

@erwango changes dones

@yboutreux yboutreux requested a review from erwango July 4, 2019 08:45
@erwango
Copy link
Collaborator

erwango commented Aug 29, 2019

@yboutreux, ok to upstream after you fix the conflict

@yboutreux yboutreux force-pushed the upstream_add_idb05a1 branch from 87eeb0b to 9c88a08 Compare August 29, 2019 07:57
@yboutreux yboutreux force-pushed the upstream_add_idb05a1 branch 3 times, most recently from 8015e5d to c9cb87e Compare August 29, 2019 08:52
@yboutreux
Copy link
Collaborator Author

Closed because went to upstream

@yboutreux yboutreux closed this Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atorgue atorgue atorgue approved these changes

@erwango erwango erwango approved these changes

@benjamingaignard benjamingaignard Awaiting requested review from benjamingaignard

@arnopo arnopo Awaiting requested review from arnopo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yboutreux @erwango @arnopo @atorgue