Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help installation along by stating the requirements. #115

Merged
merged 4 commits into from
Jan 26, 2015
Merged

Conversation

arokem
Copy link
Owner

@arokem arokem commented Jan 25, 2015

I think that pyzmq is the only hard requirement. Having numpy and ipython in
addition is probably useful, but not necessary.

@arokem
Copy link
Owner Author

arokem commented Jan 25, 2015

Maybe one of the pip/travis experts could take a look? @dhermes?

I think that pyzmq is the only hard requirement. Having numpy and ipython in
addition is probably useful, but not necessary.
@dhermes
Copy link
Contributor

dhermes commented Jan 25, 2015

SGTM.

NumPy and SciPy are also dependencies. The json import fails for old enough versions of Python, but meh.

The pymatbridge/matlab_magic.py module has IPython as a dependency, but maybe this is optional? If not, you get pyzmq transitively via ipython[all].

@arokem
Copy link
Owner Author

arokem commented Jan 25, 2015

SGTM? I will take that as a "go ahead".

I believe that numpy and scipy are optional dependencies, but I admit that I am not sure what anyone would do with this, without them.

@dhermes
Copy link
Contributor

dhermes commented Jan 25, 2015

http://www.urbandictionary.com/define.php?term=SGTM

As for optional dependencies, you can use extras_require in the setup file. For [example], see IPython.

@arokem
Copy link
Owner Author

arokem commented Jan 25, 2015

Got it. But why were you giggling? Maybe I'm missing something.

How's this?

On Sun, Jan 25, 2015 at 2:29 PM, Danny Hermes notifications@github.com
wrote:

http://www.urbandictionary.com/define.php?term=SGTM

As for optional dependencies, you can use extras_require in the setup
file. For [example], see IPython.


Reply to this email directly or view it on GitHub
#115 (comment)
.

@dhermes
Copy link
Contributor

dhermes commented Jan 26, 2015

Looks good to me (LGTM). (By the way SGTM is "sounds good to me".)

arokem added a commit that referenced this pull request Jan 26, 2015
Help installation along by stating the requirements.
@arokem arokem merged commit 17de1fd into master Jan 26, 2015
@arokem
Copy link
Owner Author

arokem commented Jan 26, 2015

Oh, sorry. urbandictionary was giving me "silently giggling to myself". I
swear.

I guess I gave you reason to giggle now.

At any rate - merging

On Sun, Jan 25, 2015 at 7:59 PM, Danny Hermes notifications@github.com
wrote:

Looks good to me (LGTM). (By the way SGTM is "sounds good to me".)


Reply to this email directly or view it on GitHub
#115 (comment)
.

@dhermes
Copy link
Contributor

dhermes commented Jan 26, 2015

Indeed. I shall commence with the giggling.

@arokem
Copy link
Owner Author

arokem commented Jan 26, 2015

Seems like the travis thing is working:
https://pypi.python.org/pypi/pymatbridge

Release notes are here:
https://github.com/arokem/python-matlab-bridge/releases/tag/0.4.1

On Sun, Jan 25, 2015 at 8:08 PM, Danny Hermes notifications@github.com
wrote:

Indeed. I shall commence with the giggling.


Reply to this email directly or view it on GitHub
#115 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants