Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Check for nargout. #135

Merged
merged 4 commits into from
Feb 14, 2015
Merged

RF: Check for nargout. #135

merged 4 commits into from
Feb 14, 2015

Conversation

arokem
Copy link
Owner

@arokem arokem commented Feb 14, 2015

No description provided.

@blink1073
Copy link
Collaborator

You're using the matlab constant nargout here, which is always 1 for this function. Like I said, we need to pass in the desired nargout (and name it something else).

@arokem
Copy link
Owner Author

arokem commented Feb 14, 2015

Closed in favor of #136

@arokem arokem closed this Feb 14, 2015
@blink1073
Copy link
Collaborator

I think you still need this PR since my PR is against yours.

@arokem
Copy link
Owner Author

arokem commented Feb 14, 2015

Oops

@arokem arokem reopened this Feb 14, 2015
Update handling of nargout
@arokem
Copy link
Owner Author

arokem commented Feb 14, 2015

OK - I merged yours in here. I can write those tests.

@blink1073
Copy link
Collaborator

Ha, okay, on a day trip with the fam.

@arokem
Copy link
Owner Author

arokem commented Feb 14, 2015

Happy Valentine's Day!

On Sat, Feb 14, 2015 at 10:22 AM, Steven Silvester <notifications@github.com

wrote:

Ha, okay, on a day trip with the fam.


Reply to this email directly or view it on GitHub
#135 (comment)
.

@blink1073
Copy link
Collaborator

Looks good to me, Happy Valentine's Day!

arokem added a commit that referenced this pull request Feb 14, 2015
@arokem arokem merged commit 580189f into master Feb 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants