Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline eval functions #146

Merged
merged 9 commits into from
Feb 18, 2015
Merged

Conversation

blink1073
Copy link
Collaborator

Major streamline of the eval logic on both the python and matlab ends. Consolidates to a single path.

Only API change: there is no more content.code output parameter for run_code calls.

@blink1073
Copy link
Collaborator Author

Question: does eval need to exist at all since it can be called using feval similar to get_variable? The only downside I see is we'd lose the content.code parameter in the return value.

@blink1073
Copy link
Collaborator Author

The symmetry was too good to pass up.

@blink1073
Copy link
Collaborator Author

I don't know what is going on with Coveralls all of a sudden.

@isbadawi
Copy link
Collaborator

Coveralls is just complaining the coverage % went down (just barely), but whatever.

LGTM.

isbadawi added a commit that referenced this pull request Feb 18, 2015
@isbadawi isbadawi merged commit 42c28a2 into arokem:master Feb 18, 2015
@blink1073
Copy link
Collaborator Author

I've seen coverage drop before and it did not call it a failure, maybe they changed their policy (I hope not).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants